Chris Wright
2009-Dec-22 18:18 UTC
[PATCH] vhost-net: comment use of invalid fd when setting vhost backend
This looks like an error case, but it's just a special case to shutdown the backend. Clarify with a comment. Signed-off-by: Chris Wright <chrisw at redhat.com> --- drivers/vhost/net.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index 22d5fef..cc92086 100644 --- a/drivers/vhost/net.c +++ b/drivers/vhost/net.c @@ -465,6 +465,7 @@ static struct socket *get_tun_socket(int fd) static struct socket *get_socket(int fd) { struct socket *sock; + /* special case to disable backend */ if (fd == -1) return NULL; sock = get_raw_socket(fd);
Michael S. Tsirkin
2009-Dec-22 19:37 UTC
[PATCH] vhost-net: comment use of invalid fd when setting vhost backend
On Tue, Dec 22, 2009 at 10:18:28AM -0800, Chris Wright wrote:> This looks like an error case, but it's just a special case to shutdown > the backend. Clarify with a comment. > > Signed-off-by: Chris Wright <chrisw at redhat.com>Acked-by: Michael S. Tsirkin <mst at redhat.com>> --- > drivers/vhost/net.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c > index 22d5fef..cc92086 100644 > --- a/drivers/vhost/net.c > +++ b/drivers/vhost/net.c > @@ -465,6 +465,7 @@ static struct socket *get_tun_socket(int fd) > static struct socket *get_socket(int fd) > { > struct socket *sock; > + /* special case to disable backend */ > if (fd == -1) > return NULL; > sock = get_raw_socket(fd);
Seemingly Similar Threads
- [PATCH] vhost-net: comment use of invalid fd when setting vhost backend
- [PATCHv6 3/3] vhost_net: a kernel-level virtio server
- [PATCHv6 3/3] vhost_net: a kernel-level virtio server
- [PATCHv9 3/3] vhost_net: a kernel-level virtio server
- [PATCHv9 3/3] vhost_net: a kernel-level virtio server