Greg Kroah-Hartman
2009-Jul-17 18:09 UTC
[patch 34/54] Staging: hv: remove STRUCT_PACKED and STRUCT_ALIGNED defines
An embedded and charset-unspecified text was scrubbed... Name: staging-hv-remove-struct_packed-and-struct_aligned-defines.patch Url: http://lists.linux-foundation.org/pipermail/virtualization/attachments/20090717/c072134f/attachment.txt
Arnd Bergmann
2009-Jul-20 23:46 UTC
[patch 34/54] Staging: hv: remove STRUCT_PACKED and STRUCT_ALIGNED defines
On Friday 17 July 2009, Greg Kroah-Hartman wrote:> @@ -43,7 +43,7 @@ typedef struct _RING_BUFFER { > // volatile u32 InterruptMask; > // Ring data starts here + RingDataStartOffset !!! DO NOT place any fields below this !!! > u8 Buffer[0]; > -} STRUCT_PACKED RING_BUFFER; > +} __attribute__((packed)) RING_BUFFER; >The data structure is actually packed already, the attribute does not make it better and could be removed. We also have __packed as a shortcut for __attribute__((packed)). Arnd <><