Laurent Vivier
2007-Aug-16 08:57 UTC
[PATCH/RFC 2/4]Introduce a new field "guest" in task_struct
PATCH 2/4] like for cpustat, introduce the "guest" and "cguest" fields for the tasks. Modify signal_struct and task_struct. Modify /proc/<pid>/stat to display these new field Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net> -- ------------- Laurent.Vivier@bull.net -------------- "Software is hard" - Donald Knuth -------------- next part -------------- Index: kvm/fs/proc/array.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kvm.orig/fs/proc/array.c 2007-08-16 15:23:52.000000000 +0200 +++ kvm/fs/proc/array.c 2007-08-16 15:36:54.000000000 +0200 @@ -354,6 +354,13 @@ return stime; } +static clock_t task_gtime(struct task_struct *p) +{ + clock_t gtime =3D cputime_to_clock_t(p->gtime); + + return gtime; +} + static int do_task_stat(struct task_struct *task, char *buffer, int whole) { unsigned long vsize, eip, esp, wchan =3D ~0UL; @@ -368,8 +375,8 @@ unsigned long long start_time; unsigned long cmin_flt =3D 0, cmaj_flt =3D 0; unsigned long min_flt =3D 0, maj_flt =3D 0; - cputime_t cutime, cstime; - clock_t utime, stime; + cputime_t cutime, cstime, cgtime; + clock_t utime, stime, gtime; unsigned long rsslim =3D 0; char tcomm[sizeof(task->comm)]; unsigned long flags; @@ -387,8 +394,8 @@ sigemptyset(&sigign); sigemptyset(&sigcatch); - cutime =3D cstime =3D cputime_zero; - utime =3D stime =3D 0; + cutime =3D cstime =3D cgtime =3D cputime_zero; + utime =3D stime =3D gtime =3D 0; rcu_read_lock(); if (lock_task_sighand(task, &flags)) { @@ -406,6 +413,7 @@ cmaj_flt =3D sig->cmaj_flt; cutime =3D sig->cutime; cstime =3D sig->cstime; + cgtime =3D sig->cgtime; rsslim =3D sig->rlim[RLIMIT_RSS].rlim_cur; /* add up live thread stats at the group level */ @@ -416,6 +424,7 @@ maj_flt +=3D t->maj_flt; utime +=3D task_utime(t); stime +=3D task_stime(t); + gtime +=3D task_gtime(t); t =3D next_thread(t); } while (t !=3D task); @@ -423,6 +432,7 @@ maj_flt +=3D sig->maj_flt; utime +=3D cputime_to_clock_t(sig->utime); stime +=3D cputime_to_clock_t(sig->stime); + gtime +=3D cputime_to_clock_t(sig->gtime); } sid =3D signal_session(sig); @@ -440,6 +450,7 @@ maj_flt =3D task->maj_flt; utime =3D task_utime(task); stime =3D task_stime(task); + gtime =3D task_gtime(task); } /* scale priority and nice values from timeslices to -20..20 */ @@ -457,7 +468,7 @@ res =3D sprintf(buffer, "%d (%s) %c %d %d %d %d %d %u %lu \ %lu %lu %lu %lu %lu %ld %ld %ld %ld %d 0 %llu %lu %ld %lu %lu %lu %lu %lu \ -%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu\n", +%lu %lu %lu %lu %lu %lu %lu %lu %d %d %u %u %llu %lu %ld\n", task->pid, tcomm, state, @@ -502,7 +513,10 @@ task_cpu(task), task->rt_priority, task->policy, - (unsigned long long)delayacct_blkio_ticks(task)); + (unsigned long long)delayacct_blkio_ticks(task), + gtime, + cputime_to_clock_t(cgtime) + ); if (mm) mmput(mm); return res; Index: kvm/include/linux/sched.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kvm.orig/include/linux/sched.h 2007-08-16 15:23:52.000000000 +0200 +++ kvm/include/linux/sched.h 2007-08-16 15:36:54.000000000 +0200 @@ -514,7 +514,7 @@ * Live threads maintain their own counters and add to these * in __exit_signal, except for the group leader. */ - cputime_t utime, stime, cutime, cstime; + cputime_t utime, stime, gtime, cutime, cstime, cgtime; unsigned long nvcsw, nivcsw, cnvcsw, cnivcsw; unsigned long min_flt, maj_flt, cmin_flt, cmaj_flt; unsigned long inblock, oublock, cinblock, coublock; @@ -1018,7 +1018,7 @@ int __user *clear_child_tid; /* CLONE_CHILD_CLEARTID */ unsigned int rt_priority; - cputime_t utime, stime; + cputime_t utime, stime, gtime; unsigned long nvcsw, nivcsw; /* context switch counts */ struct timespec start_time; /* monotonic time */ struct timespec real_start_time; /* boot based time */ Index: kvm/kernel/exit.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kvm.orig/kernel/exit.c 2007-08-16 15:23:52.000000000 +0200 +++ kvm/kernel/exit.c 2007-08-16 15:36:54.000000000 +0200 @@ -120,6 +120,7 @@ */ sig->utime =3D cputime_add(sig->utime, tsk->utime); sig->stime =3D cputime_add(sig->stime, tsk->stime); + sig->gtime =3D cputime_add(sig->gtime, tsk->gtime); sig->min_flt +=3D tsk->min_flt; sig->maj_flt +=3D tsk->maj_flt; sig->nvcsw +=3D tsk->nvcsw; @@ -1255,6 +1256,11 @@ cputime_add(p->stime, cputime_add(sig->stime, sig->cstime))); + psig->cgtime =3D + cputime_add(psig->cgtime, + cputime_add(p->gtime, + cputime_add(sig->gtime, + sig->cgtime))); psig->cmin_flt +=3D p->min_flt + sig->min_flt + sig->cmin_flt; psig->cmaj_flt +=3D Index: kvm/kernel/fork.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kvm.orig/kernel/fork.c 2007-08-16 15:23:52.000000000 +0200 +++ kvm/kernel/fork.c 2007-08-16 15:39:07.000000000 +0200 @@ -876,7 +876,8 @@ sig->leader =3D 0; /* session leadership doesn't inherit */ sig->tty_old_pgrp =3D NULL; - sig->utime =3D sig->stime =3D sig->cutime =3D sig->cstime =3D cputime_zero; + sig->utime =3D sig->stime =3D sig->gtime =3D sig->cutime =3D + sig->cstime =3D sig->cgtime =3D cputime_zero; sig->nvcsw =3D sig->nivcsw =3D sig->cnvcsw =3D sig->cnivcsw =3D 0; sig->min_flt =3D sig->maj_flt =3D sig->cmin_flt =3D sig->cmaj_flt =3D 0; sig->inblock =3D sig->oublock =3D sig->cinblock =3D sig->coublock =3D 0; @@ -1045,6 +1046,7 @@ p->utime =3D cputime_zero; p->stime =3D cputime_zero; + p->gtime =3D cputime_zero; #ifdef CONFIG_TASK_XACCT p->rchar =3D 0; /* I/O counter: bytes read */
Possibly Parallel Threads
- [PATCH/RFC 2/4]Introduce a new field "guest" in task_struct
- [PATCH 2/4] Introduce a new fields "gtime" and "cgtime" in task_struct and signal_struct
- [PATCH 2/4] Introduce a new fields "gtime" and "cgtime" in task_struct and signal_struct
- [PATCH 0/4] Virtual Machine Time Accounting
- [PATCH 0/4] Virtual Machine Time Accounting