On 18 Nov 2005, at 16:05, Andi Kleen wrote:> I don't think you can do that. We still need these functions in low > level architecture code at least. > > Using __pa/__va doesn't cut it because it won't work on Xen guests > which have different views on bus vs physical addresses. The Xen > code is (hopefully) in the process of being merged, so intentionally > breaking them isn't a good idea. > > So if anything there would need to be replacement functions for it > first that do the same thing. But why not just keep the old ones?We could make use of virt_to_machine/machine_to_virt instead, which arguably better describe the intent of those functions. Currently we only use virt_to_bus/bus_to_virt in our swiotlb implementation, and our modified dma_map code. In those files I think the existing function names make some sense, but we can easily change if that's preferred. -- Keir
Sender: ak@brahms.suse.de To: Adrian Bunk <bunk@stusta.de> Cc: linux-kernel@vger.kernel.org, virtualization@lists.osdl.org Subject: Re: [2.6 patch] mark virt_to_bus/bus_to_virt as __deprecated on i386 References: <20051118014055.GK11494@stusta.de> From: Andi Kleen <ak@suse.de> Date: 18 Nov 2005 17:05:07 +0100 In-Reply-To: <20051118014055.GK11494@stusta.de> Message-ID: <p73lkzmhrgs.fsf@brahms.suse.de> Lines: 17 User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Adrian Bunk <bunk@stusta.de> writes:> virt_to_bus/bus_to_virt are long deprecated, mark them as __deprecated > on i386.I don't think you can do that. We still need these functions in low level architecture code at least. Using __pa/__va doesn't cut it because it won't work on Xen guests which have different views on bus vs physical addresses. The Xen code is (hopefully) in the process of being merged, so intentionally breaking them isn't a good idea. So if anything there would need to be replacement functions for it first that do the same thing. But why not just keep the old ones? -Andi