Nikolay Aleksandrov
2023-May-16 11:04 UTC
[Bridge] [PATCH net-next 1/2] bridge: Add a limit on FDB entries
On 16/05/2023 13:55, Vladimir Oltean wrote:> On Tue, May 16, 2023 at 01:47:47PM +0300, Nikolay Aleksandrov wrote: >> Having the current count is just a helper, if you have a high limit dumping the table >> and counting might take awhile. Thanks for the feedback, then we'll polish and move >> on with the set for a global limit. > > Ok, but to be useful, the current count will have to be directly > comparable to the limit, I guess. So the current count will also be for > dynamically learned entries? Or is the plan to enforce the global limit > for any kind of FDB entries?That was one of the questions actually. More that I'm thinking about this, the more I want to break it apart by type because we discussed being able to specify a flag mask for the limit (all, dynamic, dynamic+static etc). If we embed these stats into a bridge fdb count attribute, it can be easily extended later if anything new comes along. If switchdev doesn't support some of these global limit configs, we can pass the option and it can deny setting it later. I think this should be more than enough as a first step.
Vladimir Oltean
2023-May-16 11:10 UTC
[Bridge] [PATCH net-next 1/2] bridge: Add a limit on FDB entries
On Tue, May 16, 2023 at 02:04:30PM +0300, Nikolay Aleksandrov wrote:> That was one of the questions actually. More that I'm thinking about this, the more > I want to break it apart by type because we discussed being able to specify a flag > mask for the limit (all, dynamic, dynamic+static etc). If we embed these stats into a > bridge fdb count attribute, it can be easily extended later if anything new comes along. > If switchdev doesn't support some of these global limit configs, we can pass the option > and it can deny setting it later. I think this should be more than enough as a first step.Ok, and by "type" you actually mean the impossibly hard to understand neighbor discovery states used by the bridge UAPI? Like having (overlapping) limits per NUD_REACHABLE, NUD_NOARP etc flags set in ndm->ndm_state? Or how should the UAPI look like?