Thomas Weißschuh
2023-Feb-14 04:23 UTC
[Bridge] [PATCH net-next v2 0/2] net: make kobj_type structures constant
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definitions to prevent modification at runtime. Signed-off-by: Thomas Wei?schuh <linux at weissschuh.net> --- Changes in v2: - drop sunrpc patch from series - use "net-next" patch prefix - Link to v1: https://lore.kernel.org/r/20230211-kobj_type-net-v1-0-e3bdaa5d8a78 at weissschuh.net --- Thomas Wei?schuh (2): net: bridge: make kobj_type structure constant net-sysfs: make kobj_type structures constant net/bridge/br_if.c | 2 +- net/core/net-sysfs.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) --- base-commit: f6feea56f66d34259c4222fa02e8171c4f2673d1 change-id: 20230211-kobj_type-net-99f71346aed2 Best regards, -- Thomas Wei?schuh <linux at weissschuh.net>
Thomas Weißschuh
2023-Feb-14 04:23 UTC
[Bridge] [PATCH net-next v2 1/2] net: bridge: make kobj_type structure constant
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definition to prevent modification at runtime. Signed-off-by: Thomas Wei?schuh <linux at weissschuh.net> --- net/bridge/br_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_if.c b/net/bridge/br_if.c index ad13b48e3e08..24f01ff113f0 100644 --- a/net/bridge/br_if.c +++ b/net/bridge/br_if.c @@ -269,7 +269,7 @@ static void brport_get_ownership(const struct kobject *kobj, kuid_t *uid, kgid_t net_ns_get_ownership(dev_net(p->dev), uid, gid); } -static struct kobj_type brport_ktype = { +static const struct kobj_type brport_ktype = { #ifdef CONFIG_SYSFS .sysfs_ops = &brport_sysfs_ops, #endif -- 2.39.1
Thomas Weißschuh
2023-Feb-14 04:23 UTC
[Bridge] [PATCH net-next v2 2/2] net-sysfs: make kobj_type structures constant
Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") the driver core allows the usage of const struct kobj_type. Take advantage of this to constify the structure definitions to prevent modification at runtime. Signed-off-by: Thomas Wei?schuh <linux at weissschuh.net> --- net/core/net-sysfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index ca55dd747d6c..a3771bba841a 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -1040,7 +1040,7 @@ static void rx_queue_get_ownership(const struct kobject *kobj, net_ns_get_ownership(net, uid, gid); } -static struct kobj_type rx_queue_ktype __ro_after_init = { +static const struct kobj_type rx_queue_ktype = { .sysfs_ops = &rx_queue_sysfs_ops, .release = rx_queue_release, .default_groups = rx_queue_default_groups, @@ -1643,7 +1643,7 @@ static void netdev_queue_get_ownership(const struct kobject *kobj, net_ns_get_ownership(net, uid, gid); } -static struct kobj_type netdev_queue_ktype __ro_after_init = { +static const struct kobj_type netdev_queue_ktype = { .sysfs_ops = &netdev_queue_sysfs_ops, .release = netdev_queue_release, .default_groups = netdev_queue_default_groups, -- 2.39.1
patchwork-bot+netdevbpf at kernel.org
2023-Feb-15 04:50 UTC
[Bridge] [PATCH net-next v2 0/2] net: make kobj_type structures constant
Hello: This series was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba at kernel.org>: On Tue, 14 Feb 2023 04:23:10 +0000 you wrote:> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.") > the driver core allows the usage of const struct kobj_type. > > Take advantage of this to constify the structure definitions to prevent > modification at runtime. > > Signed-off-by: Thomas Wei?schuh <linux at weissschuh.net> > > [...]Here is the summary with links: - [net-next,v2,1/2] net: bridge: make kobj_type structure constant https://git.kernel.org/netdev/net-next/c/e8c6cbd7656e - [net-next,v2,2/2] net-sysfs: make kobj_type structures constant https://git.kernel.org/netdev/net-next/c/b2793517052d You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html