netdev at kapio-technology.com
2022-Aug-23 11:41 UTC
[Bridge] [PATCH v4 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers
On 2022-08-23 08:48, Ido Schimmel wrote:> > I'm not good at naming, but "blackhole" is at least consistent with > what > we already have for routes and nexthop objects. >I have changed it the name "masked", as that is also the term used in the documentation for the zero-DPV entries, and I think that it will generally be a more accepted term. Thus the name of the flag is now "BR_FDB_ENTRY_MASKED". I hope that is fine with you?
Ido Schimmel
2022-Aug-25 09:36 UTC
[Bridge] [PATCH v4 net-next 3/6] drivers: net: dsa: add locked fdb entry flag to drivers
On Tue, Aug 23, 2022 at 01:41:51PM +0200, netdev at kapio-technology.com wrote:> On 2022-08-23 08:48, Ido Schimmel wrote: > > > > I'm not good at naming, but "blackhole" is at least consistent with what > > we already have for routes and nexthop objects. > > > > I have changed it the name "masked", as that is also the term used in the > documentation for the zero-DPV entries, and I think that it will generally > be a more accepted term."blackhole" is an already accepted term and at least to me it is much more clear than "masked". Keep in mind that both L2 neighbours (FDB) and L3 neighbours share the same uAPI and eventually we might want to extend the use of this flag for L3 neighbours (at least Spectrum supports it), so it needs to make sense for both.