Joachim Wiberg
2022-Feb-24 16:29 UTC
[Bridge] [PATCH 1/1 net-next] net: bridge: add support for host l2 mdb entries
On Thu, Feb 24, 2022 at 08:06, Jakub Kicinski <kuba at kernel.org> wrote:> On Thu, 24 Feb 2022 13:26:22 +0200 Nikolay Aleksandrov wrote: >> On 23/02/2022 19:24, Joachim Wiberg wrote: >> > This patch expands on the earlier work on layer-2 mdb entries by adding >> > support for host entries. >> It would be nice to add a selftest for L2 entries. You can send it as a follow-up. > Let's wait for that, also checkpatch says you need to balance brackets > to hold kernel coding style.Jakub, by "wait for that" do you mean you'd prefer I add the selftests to this? Otherwise I'll send a v2 with the style fixes. Best regards /Joachim
Jakub Kicinski
2022-Feb-24 16:48 UTC
[Bridge] [PATCH 1/1 net-next] net: bridge: add support for host l2 mdb entries
On Thu, 24 Feb 2022 17:29:35 +0100 Joachim Wiberg wrote:> On Thu, Feb 24, 2022 at 08:06, Jakub Kicinski <kuba at kernel.org> wrote: > > On Thu, 24 Feb 2022 13:26:22 +0200 Nikolay Aleksandrov wrote: > >> On 23/02/2022 19:24, Joachim Wiberg wrote: > [...] > >> It would be nice to add a selftest for L2 entries. You can send it as a follow-up. > > Let's wait for that, also checkpatch says you need to balance brackets > > to hold kernel coding style. > > Jakub, by "wait for that" do you mean you'd prefer I add the selftests > to this?Yes, add a selftest as a separate patch but in the same series.