Jakub Kicinski
2022-Feb-15 05:13 UTC
[Bridge] [PATCH] net: bridge: multicast: notify switchdev driver whenever MC processing gets disabled
On Fri, 11 Feb 2022 15:14:26 +0200 Oleksandr Mazur wrote:> Whenever bridge driver hits the max capacity of MDBs, it disables > the MC processing (by setting corresponding bridge option), but never > notifies switchdev about such change (the notifiers are called only upon > explicit setting of this option, through the registered netlink interface). > > This could lead to situation when Software MDB processing gets disabled, > but this event never gets offloaded to the underlying Hardware. > > Fix this by adding a notify message in such case.Any comments on this one? We have drivers offloading mdb so presumably this should have a Fixes tag and go to net, right?
Nikolay Aleksandrov
2022-Feb-15 08:31 UTC
[Bridge] [PATCH] net: bridge: multicast: notify switchdev driver whenever MC processing gets disabled
(+CC Ido) On 15/02/2022 07:13, Jakub Kicinski wrote:> On Fri, 11 Feb 2022 15:14:26 +0200 Oleksandr Mazur wrote: >> Whenever bridge driver hits the max capacity of MDBs, it disables >> the MC processing (by setting corresponding bridge option), but never >> notifies switchdev about such change (the notifiers are called only upon >> explicit setting of this option, through the registered netlink interface). >> >> This could lead to situation when Software MDB processing gets disabled, >> but this event never gets offloaded to the underlying Hardware. >> >> Fix this by adding a notify message in such case. > > Any comments on this one? > > We have drivers offloading mdb so presumably this should have a Fixes > tag and go to net, right?The change looks ok, but it'd be nice to get switchdev folks comment as well. About the tree, -net should be targeted. I think the issue has existed since mdb disabled could be offloaded, so the tag should be: Fixes: 147c1e9b902c ("switchdev: bridge: Offload multicast disabled")