Hans Schultz
2022-Feb-07 10:07 UTC
[Bridge] [PATCH net-next 2/4] net: bridge: dsa: Add support for offloading of locked port flag
Various switchcores support setting ports in locked mode, so that
clients behind locked ports cannot send traffic through the port
unless a fdb entry is added with the clients MAC address.
Among the switchcores that support this feature is the Marvell
mv88e6xxx family.
Signed-off-by: Hans Schultz <schultz.hans+netdev at gmail.com>
---
net/bridge/br_switchdev.c | 2 +-
net/dsa/port.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/bridge/br_switchdev.c b/net/bridge/br_switchdev.c
index f8fbaaa7c501..bf549fc22556 100644
--- a/net/bridge/br_switchdev.c
+++ b/net/bridge/br_switchdev.c
@@ -72,7 +72,7 @@ bool nbp_switchdev_allowed_egress(const struct net_bridge_port
*p,
/* Flags that can be offloaded to hardware */
#define BR_PORT_FLAGS_HW_OFFLOAD (BR_LEARNING | BR_FLOOD | \
- BR_MCAST_FLOOD | BR_BCAST_FLOOD)
+ BR_MCAST_FLOOD | BR_BCAST_FLOOD | BR_PORT_LOCKED)
int br_switchdev_set_port_flag(struct net_bridge_port *p,
unsigned long flags,
diff --git a/net/dsa/port.c b/net/dsa/port.c
index bd78192e0e47..01ed22ed74a1 100644
--- a/net/dsa/port.c
+++ b/net/dsa/port.c
@@ -176,7 +176,7 @@ static int dsa_port_inherit_brport_flags(struct dsa_port
*dp,
struct netlink_ext_ack *extack)
{
const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD |
- BR_BCAST_FLOOD;
+ BR_BCAST_FLOOD | BR_PORT_LOCKED;
struct net_device *brport_dev = dsa_port_to_bridge_port(dp);
int flag, err;
@@ -200,7 +200,7 @@ static void dsa_port_clear_brport_flags(struct dsa_port *dp)
{
const unsigned long val = BR_FLOOD | BR_MCAST_FLOOD | BR_BCAST_FLOOD;
const unsigned long mask = BR_LEARNING | BR_FLOOD | BR_MCAST_FLOOD |
- BR_BCAST_FLOOD;
+ BR_BCAST_FLOOD | BR_PORT_LOCKED;
int flag, err;
for_each_set_bit(flag, &mask, 32) {
--
2.30.2
Nikolay Aleksandrov
2022-Feb-07 10:51 UTC
[Bridge] [PATCH net-next 2/4] net: bridge: dsa: Add support for offloading of locked port flag
On 07/02/2022 12:07, Hans Schultz wrote:> Various switchcores support setting ports in locked mode, so that > clients behind locked ports cannot send traffic through the port > unless a fdb entry is added with the clients MAC address. > > Among the switchcores that support this feature is the Marvell > mv88e6xxx family. > > Signed-off-by: Hans Schultz <schultz.hans+netdev at gmail.com> > --- > net/bridge/br_switchdev.c | 2 +- > net/dsa/port.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) >Hi, For some reason I still haven't received patch 01 which adds this new flag, so I'll comment on this patch first. These should be 2 separate patches, there is no bridge: dsa:. Please break them into a bridge: and dsa: parts that add the flag, it also makes it easier for people who have to backport patches and fixes later. In addition please mention in the commit message why the flag is added there, i.e. in order to allow to be offloaded. Thanks, Nik