Linux Ethernet Bridging - Aug 2021 - [Bridge] [PATCH net-next 00/15] net: bridge: multicast: add vlan support

Hi Hik, everyone!

On Mon, Jul 19, 2021 at 20:06, Nikolay Aleksandrov <razor at
blackwall.org> wrote:
> From: Nikolay Aleksandrov <nikolay at nvidia.com>
> This patchset adds initial per-vlan multicast support, most of the code
> deals with moving to multicast context pointers from bridge/port pointers.
Awesome work, this looks very interesting! :)  I've already built and
tested net-next for regressions on Marvell SOHO switches, looking good
so far.

Curious, are you planning querier per-vlan, including use-ifaddr support
as well?  In our in-house hack, which I posted a few years ago, we added
some "dumpster diving" to inet_select_addr(), but it got rather
tricky.
So I've been leaning towards having that in userspace instead.
> Future patch-sets which build on this one (in order):
>  - iproute2 support for all the new uAPIs
I'm very eager to try out all the new IGMP per-VLAN stuff, do you have
any branch of the iproute2 support available yet for testing?  For now
I've hard-coded BROPT_MCAST_VLAN_SNOOPING_ENABLED in br_multicast_init()
as a workaround, and everything seems to work just as expected :-)

Best regards
 /Joachim

On 19/08/2021 19:01, Joachim Wiberg wrote:
> Hi Hik, everyone!
> 
Hi,
> On Mon, Jul 19, 2021 at 20:06, Nikolay Aleksandrov <razor at
blackwall.org> wrote:
>> From: Nikolay Aleksandrov <nikolay at nvidia.com>
>> This patchset adds initial per-vlan multicast support, most of the code
>> deals with moving to multicast context pointers from bridge/port
pointers.
> 
> Awesome work, this looks very interesting! :)  I've already built and
> tested net-next for regressions on Marvell SOHO switches, looking good
> so far.
> 
> Curious, are you planning querier per-vlan, including use-ifaddr support
> as well?  In our in-house hack, which I posted a few years ago, we added
> some "dumpster diving" to inet_select_addr(), but it got rather
tricky.
> So I've been leaning towards having that in userspace instead.
> 
Yes, that is already supported (use-ifaddr needs attention though). In my next
patch-set where I added the initial global vlan mcast options I added control
for per-vlan querier with per-vlan querier elections and so on. The use-ifaddr
needs more work though, that's why I still haven't added that option. I
need
to add the per-vlan/port router control option so we'll have mostly
everything
ready in a single release.
>> Future patch-sets which build on this one (in order):
>>  - iproute2 support for all the new uAPIs
> 
> I'm very eager to try out all the new IGMP per-VLAN stuff, do you have
> any branch of the iproute2 support available yet for testing?  For now
> I've hard-coded BROPT_MCAST_VLAN_SNOOPING_ENABLED in
br_multicast_init()
> as a workaround, and everything seems to work just as expected :-)
I don't have it public yet because I need to polish the support, currently
it's very rough, enough for testing purposes for these patch-sets. :)
I plan to work on that after I finish with the per-vlan/port router control.
> 
> Best regards
>  /Joachim
> 
Thanks,
 Nik