Jason Yan
2020-May-06 06:17 UTC
[Bridge] [PATCH net-next] net: bridge: return false in br_mrp_enabled()
Fix the following coccicheck warning:
net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function
'br_mrp_enabled' with return type bool
Signed-off-by: Jason Yan <yanaijie at huawei.com>
---
net/bridge/br_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h
index c35647cb138a..78d3a951180d 100644
--- a/net/bridge/br_private.h
+++ b/net/bridge/br_private.h
@@ -1331,7 +1331,7 @@ static inline int br_mrp_process(struct net_bridge_port
*p, struct sk_buff *skb)
static inline bool br_mrp_enabled(struct net_bridge *br)
{
- return 0;
+ return false;
}
static inline void br_mrp_port_del(struct net_bridge *br,
--
2.21.1
Nikolay Aleksandrov
2020-May-06 09:47 UTC
[Bridge] [PATCH net-next] net: bridge: return false in br_mrp_enabled()
On 06/05/2020 09:16, Jason Yan wrote:> Fix the following coccicheck warning: > > net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function > 'br_mrp_enabled' with return type bool > > Signed-off-by: Jason Yan <yanaijie at huawei.com> > --- > net/bridge/br_private.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/bridge/br_private.h b/net/bridge/br_private.h > index c35647cb138a..78d3a951180d 100644 > --- a/net/bridge/br_private.h > +++ b/net/bridge/br_private.h > @@ -1331,7 +1331,7 @@ static inline int br_mrp_process(struct net_bridge_port *p, struct sk_buff *skb) > > static inline bool br_mrp_enabled(struct net_bridge *br) > { > - return 0; > + return false; > } > > static inline void br_mrp_port_del(struct net_bridge *br, >Fixes: 6536993371fab ("bridge: mrp: Integrate MRP into the bridge") Acked-by: Nikolay Aleksandrov <nikolay at cumulusnetworks.com>
David Miller
2020-May-06 20:57 UTC
[Bridge] [PATCH net-next] net: bridge: return false in br_mrp_enabled()
From: Jason Yan <yanaijie at huawei.com> Date: Wed, 6 May 2020 14:16:16 +0800> Fix the following coccicheck warning: > > net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function > 'br_mrp_enabled' with return type bool > > Signed-off-by: Jason Yan <yanaijie at huawei.com>Applied.