David Miller
2020-Jan-10 19:27 UTC
[Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)
From: Nikolay Aleksandrov <nikolay at cumulusnetworks.com> Date: Fri, 10 Jan 2020 16:13:36 +0200> I agree with Stephen here, IMO you have to take note of how STP has progressed > and that bringing it in the kernel was a mistake, these days mstpd has an active > community and much better support which is being extended. This looks best implemented > in user-space in my opinion with minimal kernel changes to support it. You could simply > open a packet socket with a filter and work through that, you don't need new netlink > sockets. I'm not familiar with the protocol so can't really be the judge of that, if > you present a good argument for needing a new netlink socket for these packets - then > sure, ok.With a userland implementation, what approach do you suggest for DSA/switchdev offload of this stuff?
nikolay at cumulusnetworks.com
2020-Jan-10 20:03 UTC
[Bridge] [RFC net-next Patch 0/3] net: bridge: mrp: Add support for Media Redundancy Protocol(MRP)
On 10 January 2020 21:27:36 EET, David Miller <davem at davemloft.net> wrote:>From: Nikolay Aleksandrov <nikolay at cumulusnetworks.com> >Date: Fri, 10 Jan 2020 16:13:36 +0200 > >> I agree with Stephen here, IMO you have to take note of how STP has >progressed >> and that bringing it in the kernel was a mistake, these days mstpd >has an active >> community and much better support which is being extended. This looks >best implemented >> in user-space in my opinion with minimal kernel changes to support >it. You could simply >> open a packet socket with a filter and work through that, you don't >need new netlink >> sockets. I'm not familiar with the protocol so can't really be the >judge of that, if >> you present a good argument for needing a new netlink socket for >these packets - then >> sure, ok. > >With a userland implementation, what approach do you suggest for >DSA/switchdev offload >of this stuff?Good question, there was no mention of that initially, or I missed it at least. There aren't many details about what/how will be offloaded right now. We need more information about what will be offloaded and how it will fit. l