David Miller
2019-Feb-12 17:50 UTC
[Bridge] [PATCH net-next 0/3] Remove getting SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
From: Florian Fainelli <f.fainelli at gmail.com> Date: Mon, 11 Feb 2019 13:17:46 -0800> AFAICT there is no code that attempts to get the value of the attribute > SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with > switchdev_port_attr_set(). > > This is effectively no doing anything and it can slow down future work > that tries to make modifications in these areas so remove that.Series applied.> David, there should be no dependency with previous patch series, but > again, feedback from Ido and Jiri would be welcome in case this was > added for a reason.Ok, is there going to be another respin of that switchdev_ops removal series?
Florian Fainelli
2019-Feb-12 17:54 UTC
[Bridge] [PATCH net-next 0/3] Remove getting SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS
On 2/12/19 9:50 AM, David Miller wrote:> From: Florian Fainelli <f.fainelli at gmail.com> > Date: Mon, 11 Feb 2019 13:17:46 -0800 > >> AFAICT there is no code that attempts to get the value of the attribute >> SWITCHDEV_ATTR_ID_PORT_BRIDGE_FLAGS while it is used with >> switchdev_port_attr_set(). >> >> This is effectively no doing anything and it can slow down future work >> that tries to make modifications in these areas so remove that. > > Series applied. > >> David, there should be no dependency with previous patch series, but >> again, feedback from Ido and Jiri would be welcome in case this was >> added for a reason. > > Ok, is there going to be another respin of that switchdev_ops removal > series?Yes, I will be working on a v5 which addresses Ido's feedback in the next hours. -- Florian