Linux Ethernet Bridging - Jan 2019 - [Bridge] [PATCH net v2] net: bridge: Fix ethernet header pointer before check skb forwardable

From: Yunjian Wang <wangyunjian at huawei.com>

The skb header should be set to ethernet header before using
is_skb_forwardable. Because the ethernet header length has been
considered in is_skb_forwardable(including dev->hard_header_len
length).

To reproduce the issue:
1, add 2 ports on linux bridge br using following commands:
$ brctl addbr br
$ brctl addif br eth0
$ brctl addif br eth1
2, the mtu of eth0 and eth1 is 1500
3, send a 1504 packet from eth0 to eth1

So the expect result is packet larger than 1500 cannot pass through
eth0 and eth1. But currently, the packet passes through success, it
means eth1's mtu limit donen't take effect.

Fixes: f6367b4660dd ("bridge: use is_skb_forwardable in forward path")
Cc: bridge at lists.linux-foundation.org
Cc: Nkolay Aleksandrov <nikolay at cumulusnetworks.com>
Cc: Roopa Prabhu <roopa at cumulusnetworks.com>
Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
---
v2:
 -fix commit log and cc the bridge maintainers with fixes tags
---
 net/bridge/br_forward.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c
index 5372e20..74b688b 100644
--- a/net/bridge/br_forward.c
+++ b/net/bridge/br_forward.c
@@ -36,10 +36,10 @@ static inline int should_deliver(const struct
net_bridge_port *p,
 
 int br_dev_queue_push_xmit(struct net *net, struct sock *sk, struct sk_buff
*skb)
 {
+	skb_push(skb, ETH_HLEN);
 	if (!is_skb_forwardable(skb->dev, skb))
 		goto drop;
 
-	skb_push(skb, ETH_HLEN);
 	br_drop_fake_rtable(skb);
 
 	if (skb->ip_summed == CHECKSUM_PARTIAL &&
@@ -97,10 +97,10 @@ static void __br_forward(const struct net_bridge_port *to,
 		net = dev_net(indev);
 	} else {
 		if (unlikely(netpoll_tx_running(to->br->dev))) {
+			skb_push(skb, ETH_HLEN);
 			if (!is_skb_forwardable(skb->dev, skb)) {
 				kfree_skb(skb);
 			} else {
-				skb_push(skb, ETH_HLEN);
 				br_netpoll_send_skb(to, skb);
 			}
 			return;
-- 
1.8.3.1

On 2019/01/15 12:12, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian at huawei.com>
> 
> The skb header should be set to ethernet header before using
> is_skb_forwardable. Because the ethernet header length has been
> considered in is_skb_forwardable(including dev->hard_header_len
> length).
> 
> To reproduce the issue:
> 1, add 2 ports on linux bridge br using following commands:
> $ brctl addbr br
> $ brctl addif br eth0
> $ brctl addif br eth1
> 2, the mtu of eth0 and eth1 is 1500
> 3, send a 1504 packet from eth0 to eth1
> 
> So the expect result is packet larger than 1500 cannot pass through
> eth0 and eth1. But currently, the packet passes through success, it
> means eth1's mtu limit donen't take effect.
I agree with the change but this test does not look appropriate.
In the first place is_skb_forwardable() accepts 4 bytes extra size (for
VLAN header). Doesn't your test case fail even after the change?

-- 
Toshiaki Makita

On 15.01.2019 6:12, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian at huawei.com>
> 
> The skb header should be set to ethernet header before using
> is_skb_forwardable. Because the ethernet header length has been
> considered in is_skb_forwardable(including dev->hard_header_len
> length).
> 
> To reproduce the issue:
> 1, add 2 ports on linux bridge br using following commands:
> $ brctl addbr br
> $ brctl addif br eth0
> $ brctl addif br eth1
> 2, the mtu of eth0 and eth1 is 1500
> 3, send a 1504 packet from eth0 to eth1
> 
> So the expect result is packet larger than 1500 cannot pass through
> eth0 and eth1. But currently, the packet passes through success, it
> means eth1's mtu limit donen't take effect.
    Doesn't. And MTU.
> Fixes: f6367b4660dd ("bridge: use is_skb_forwardable in forward
path")
> Cc: bridge at lists.linux-foundation.org
> Cc: Nkolay Aleksandrov <nikolay at cumulusnetworks.com>
> Cc: Roopa Prabhu <roopa at cumulusnetworks.com>
> Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
[...]

MBR, Sergei