Nikolay Aleksandrov
2018-Jul-20 17:26 UTC
[Bridge] [PATCH net-next 1/2] net: bridge: add support for raw sysfs port options
On July 20, 2018 8:20:44 PM GMT+03:00, Stephen Hemminger <stephen at networkplumber.org> wrote:>On Fri, 20 Jul 2018 20:14:43 +0300 >Nikolay Aleksandrov <nikolay at cumulusnetworks.com> wrote: > >> >Casting away the const on the buf variable is going to cause >warnings >> >and should not be necessary. >> > >> >> It doesn't when it's casted like that, the new line is changed to >null byte so we need to drop >> the const. > >Then change store function to take a char *?Sure, will do.
Nikolay Aleksandrov
2018-Jul-20 17:47 UTC
[Bridge] [PATCH net-next 1/2] net: bridge: add support for raw sysfs port options
On July 20, 2018 8:26:36 PM GMT+03:00, Nikolay Aleksandrov <nikolay at cumulusnetworks.com> wrote:>On July 20, 2018 8:20:44 PM GMT+03:00, Stephen Hemminger ><stephen at networkplumber.org> wrote: >>On Fri, 20 Jul 2018 20:14:43 +0300 >>Nikolay Aleksandrov <nikolay at cumulusnetworks.com> wrote: >> >>> >Casting away the const on the buf variable is going to cause >>warnings >>> >and should not be necessary. >>> > >>> >>> It doesn't when it's casted like that, the new line is changed to >>null byte so we need to drop >>> the const. >> >>Then change store function to take a char *? > >Sure, will do.Acrually I can't change sysfs_ops store prototype. That is the reason the bond also casts the ptr.