Colin King
2017-Oct-16 10:24 UTC
[Bridge] [PATCH] netfilter: ebtables: clean up initialization of buf
From: Colin Ian King <colin.king at canonical.com>
buf is initialized to buf_start and then set on the next statement
to buf_start + offsets[i]. Clean this up to just initialize buf
to buf_start + offsets[i] to clean up the clang build warning:
"Value stored to 'buf' during its initialization is never
read"
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
net/bridge/netfilter/ebtables.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c
index 3b3dcf719e07..37817d25b63d 100644
--- a/net/bridge/netfilter/ebtables.c
+++ b/net/bridge/netfilter/ebtables.c
@@ -2112,9 +2112,8 @@ static int size_entry_mwt(struct ebt_entry *entry, const
unsigned char *base,
for (i = 0, j = 1 ; j < 4 ; j++, i++) {
struct compat_ebt_entry_mwt *match32;
unsigned int size;
- char *buf = buf_start;
+ char *buf = buf_start + offsets[i];
- buf = buf_start + offsets[i];
if (offsets[i] > offsets[j])
return -EINVAL;
--
2.14.1
Pablo Neira Ayuso
2017-Nov-06 13:50 UTC
[Bridge] [PATCH] netfilter: ebtables: clean up initialization of buf
On Mon, Oct 16, 2017 at 11:24:02AM +0100, Colin King wrote:> From: Colin Ian King <colin.king at canonical.com> > > buf is initialized to buf_start and then set on the next statement > to buf_start + offsets[i]. Clean this up to just initialize buf > to buf_start + offsets[i] to clean up the clang build warning: > "Value stored to 'buf' during its initialization is never read"Applied, thanks.