Mark Brown
2014-Nov-13 11:33 UTC
[Bridge] arm64 allmodconfig failures in nft_reject_bridge.c
Since about -rc3 we've been seeing build failures in Linus' tree on arm64 allmodconfig due to:> arm64-allmodconfig > ../net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration]By the time I looked into this it was fixed in -next by c1207c049b204b0 (netfilter: nft_reject_bridge: Fix powerpc build error) from Guenter but that doesn't seem to have made it into -rc4 so I just wanted to check that this fix was intended to go to Linus before v3.18? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.linuxfoundation.org/pipermail/bridge/attachments/20141113/982aed19/attachment.sig>
Pablo Neira Ayuso
2014-Nov-13 11:43 UTC
[Bridge] arm64 allmodconfig failures in nft_reject_bridge.c
On Thu, Nov 13, 2014 at 11:33:20AM +0000, Mark Brown wrote:> Since about -rc3 we've been seeing build failures in Linus' tree on > arm64 allmodconfig due to: > > > arm64-allmodconfig > > ../net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration] > > By the time I looked into this it was fixed in -next by c1207c049b204b0 > (netfilter: nft_reject_bridge: Fix powerpc build error) from Guenter but > that doesn't seem to have made it into -rc4 so I just wanted to check > that this fix was intended to go to Linus before v3.18?I can see this in David's tree: http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=c1207c049b204b0a96535dc5416aee331b51e0e1 I think this was reported by when -rc4 was already out, so you'll see this by -rc5.
Mark Brown
2014-Nov-13 12:51 UTC
[Bridge] arm64 allmodconfig failures in nft_reject_bridge.c
On Thu, Nov 13, 2014 at 12:43:57PM +0100, Pablo Neira Ayuso wrote:> I can see this in David's tree:> http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=c1207c049b204b0a96535dc5416aee331b51e0e1> I think this was reported by when -rc4 was already out, so you'll see > this by -rc5.The fix predates -rc4 (sent on the 2nd, committed on the 3rd, -rc4 was on the 9th), I'd been expecting to see it turn up there or shortly after. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 473 bytes Desc: Digital signature URL: <http://lists.linuxfoundation.org/pipermail/bridge/attachments/20141113/c73576cb/attachment.sig>
David Miller
2014-Nov-13 19:35 UTC
[Bridge] arm64 allmodconfig failures in nft_reject_bridge.c
From: Pablo Neira Ayuso <pablo at netfilter.org> Date: Thu, 13 Nov 2014 12:43:57 +0100> On Thu, Nov 13, 2014 at 11:33:20AM +0000, Mark Brown wrote: >> Since about -rc3 we've been seeing build failures in Linus' tree on >> arm64 allmodconfig due to: >> >> > arm64-allmodconfig >> > ../net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' [-Werror=implicit-function-declaration] >> >> By the time I looked into this it was fixed in -next by c1207c049b204b0 >> (netfilter: nft_reject_bridge: Fix powerpc build error) from Guenter but >> that doesn't seem to have made it into -rc4 so I just wanted to check >> that this fix was intended to go to Linus before v3.18? > > I can see this in David's tree: > > http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=c1207c049b204b0a96535dc5416aee331b51e0e1 > > I think this was reported by when -rc4 was already out, so you'll see > this by -rc5.I hold changes in my tree for a week or more, because I want them to "cook" there before they go to Linus. So if it takes a week or two for a bug fix like this to propagate into Linus's tree, that's just what sometimes happens. In the mean time you can apply the fix locally if you absolutely have to have it right at this moment, that is the freedom that everyone has. FWIW, I plan to push my tree to Linus some time today, so this will be resolved in the next day or so. Thanks.