Toshiaki Makita
2014-Sep-14 15:21 UTC
[Bridge] [PATCH 2/3] bridge: Add filtering support for default_pvid
(14/09/13 (?) 5:44), Vladislav Yasevich wrote:> Currently when vlan filtering is turned on on the bridge, the bridge > will drop all traffic untill the user configures the filter. This > isn't very nice for ports that don't care about vlans and just > want untagged traffic. > > A concept of a default_pvid was recently introduced. This patch > adds filtering support for default_pvid. Now, ports that don't > care about vlans and don't define there own filter will belong > to the VLAN of the default_pvid and continue to receive untagged > traffic.If user sets pvid, then vid 1 (default_pvid) will become non-pvid but still not be filtered, right? vlan_bitmap of default_pvid shouldn't be cleared on setting pvid? Thanks, Toshiaki Makita
Vlad Yasevich
2014-Sep-15 15:09 UTC
[Bridge] [PATCH 2/3] bridge: Add filtering support for default_pvid
On 09/14/2014 11:21 AM, Toshiaki Makita wrote:> (14/09/13 (?) 5:44), Vladislav Yasevich wrote: >> Currently when vlan filtering is turned on on the bridge, the bridge >> will drop all traffic untill the user configures the filter. This >> isn't very nice for ports that don't care about vlans and just >> want untagged traffic. >> >> A concept of a default_pvid was recently introduced. This patch >> adds filtering support for default_pvid. Now, ports that don't >> care about vlans and don't define there own filter will belong >> to the VLAN of the default_pvid and continue to receive untagged >> traffic. > > If user sets pvid, then vid 1 (default_pvid) will become non-pvid but > still not be filtered, right?Right.> vlan_bitmap of default_pvid shouldn't be cleared on setting pvid?I can see arguments for both. Just because the user wishes to set a different pvid may not always mean that vlan associated with default pvid shouldn't be filtered. I think it's at user's discretion. I hesitate to do too many things automatically. -vlad> > Thanks, > Toshiaki Makita >