Linux Ethernet Bridging - Aug 2013 - [Bridge] [PATCH] rtnetlink: rtnl_bridge_getlink: Call nlmsg_find_attr() with ifinfomsg header

On 08/12/2013 12:30 PM, Asbjoern Sloth Toennesen wrote:
> Fix the iproute2 command `bridge vlan show`, after switching from
> rtgenmsg to ifinfomsg.
>
> Signed-off-by: Asbjoern Sloth Toennesen <ast at fiberby.net>

Thanks..  I've still been using an older iproute version and didn't see 
this.


Reviewed-by: Vlad Yasevich <vyasevich at
gmail.com>
> ---
>   net/core/rtnetlink.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
> index 3de7408..a043171 100644
> --- a/net/core/rtnetlink.c
> +++ b/net/core/rtnetlink.c
> @@ -2384,7 +2384,7 @@ static int rtnl_bridge_getlink(struct sk_buff *skb,
struct netlink_callback *cb)
>   	struct nlattr *extfilt;
>   	u32 filter_mask = 0;
>
> -	extfilt = nlmsg_find_attr(cb->nlh, sizeof(struct rtgenmsg),
> +	extfilt = nlmsg_find_attr(cb->nlh, sizeof(struct ifinfomsg),
>   				  IFLA_EXT_MASK);
>   	if (extfilt)
>   		filter_mask = nla_get_u32(extfilt);
>

From: Vlad Yasevich <vyasevic at redhat.com>
Date: Mon, 12 Aug 2013 15:57:29 -0400
> On 08/12/2013 12:30 PM, Asbjoern Sloth Toennesen wrote:
>> Fix the iproute2 command `bridge vlan show`, after switching from
>> rtgenmsg to ifinfomsg.
>>
>> Signed-off-by: Asbjoern Sloth Toennesen <ast at fiberby.net>
> 
> 
> Thanks..  I've still been using an older iproute version and didn't
> see this.
> 
> 
> Reviewed-by: Vlad Yasevich <vyasevich at gmail.com>
What introduced this regression?