Silviu-Mihai Popescu
2013-Mar-12 18:11 UTC
[Bridge] [PATCH] bridge: netfilter: use PTR_RET instead of IS_ERR + PTR_ERR
This uses PTR_RET instead of IS_ERR and PTR_ERR in order to increase readability. Signed-off-by: Silviu-Mihai Popescu <silviupopescu1990 at gmail.com> --- net/bridge/netfilter/ebtable_broute.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/bridge/netfilter/ebtable_broute.c b/net/bridge/netfilter/ebtable_broute.c index 40d8258..70f656c 100644 --- a/net/bridge/netfilter/ebtable_broute.c +++ b/net/bridge/netfilter/ebtable_broute.c @@ -64,9 +64,7 @@ static int ebt_broute(struct sk_buff *skb) static int __net_init broute_net_init(struct net *net) { net->xt.broute_table = ebt_register_table(net, &broute_table); - if (IS_ERR(net->xt.broute_table)) - return PTR_ERR(net->xt.broute_table); - return 0; + return PTR_RET(net->xt.broute_table); } static void __net_exit broute_net_exit(struct net *net) -- 1.7.9.5
Pablo Neira Ayuso
2013-Mar-15 11:48 UTC
[Bridge] [PATCH] bridge: netfilter: use PTR_RET instead of IS_ERR + PTR_ERR
On Tue, Mar 12, 2013 at 08:11:33PM +0200, Silviu-Mihai Popescu wrote:> This uses PTR_RET instead of IS_ERR and PTR_ERR in order to increase > readability.Also applied, thanks.