Linux Ethernet Bridging - Aug 2011 - [Bridge] possible bridge regression in "bridge: implement [add/del]_slave ops"?

Hello,

I had trouble with the new detection code for interface ports. 
In turned out that the carrier was down, but IFF_RUNNING was set. 
I changed the code to check for IFF_UP & IFF_LOWER_UP for interface ports
and now it works the way it should.
Would it be better to check IFF_LOWER_UP or is my interface device driver
incorrect?

Best regards,
Bernhard


----------------------------------------------------------------------

From: Stephen Hemminger <shemminger at linux-foundation.org>
Subject: Re: [Bridge] possible bridge regression in "bridge: implement
        [add/del]_slave ops"?
To: Alexander Stein <alexander.stein at systec-electronic.com>
Cc: netdev at vger.kernel.org, bridge at lists.linux-foundation.org, 
"David
        S. Miller" <davem at davemloft.net>, linux-kernel at
vger.kernel.org
Message-ID: <20110705142858.3b7e5941 at nehalam.ftrdhcpuser.net>
Content-Type: text/plain; charset=US-ASCII

I just put a fix for the detection of bridge pseudo-device being up
into the current rstp code available at:
  git://git.kernel.org/pub/scm/linux/kernel/git/shemminger/rstp.git


------------------------------

_______________________________________________
Bridge mailing list
Bridge at lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/bridge

End of Bridge Digest, Vol 95, Issue 3
*************************************

On Wed, 10 Aug 2011 09:54:58 +0200
"Weirich, Bernhard" <Bernhard.Weirich at riedel.net> wrote:
> Hello,
> 
> I had trouble with the new detection code for interface ports. 
> In turned out that the carrier was down, but IFF_RUNNING was set. 
> I changed the code to check for IFF_UP & IFF_LOWER_UP for interface
ports and now it works the way it should.
> Would it be better to check IFF_LOWER_UP or is my interface device driver
incorrect?
> 
> Best regards,
> Bernhard
The standard for carrier up is IFF_RUNNING. IFF_LOWER_UP is meant for
use by modems and other special devies.