Linux Ethernet Bridging - Jul 2011 - [Bridge] [PATCH][TRIVIAL] net, netfilter: Remove redundant goto in ebt_ulog_packet

In net/bridge/netfilter/ebt_ulog.c:ebt_ulog_packet() the 'goto unlock'
before the 'alloc_failure' label is completely redundant. This patch
removes it.

Signed-off-by: Jesper Juhl <jj at chaosbits.net>
---
 net/bridge/netfilter/ebt_ulog.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/net/bridge/netfilter/ebt_ulog.c b/net/bridge/netfilter/ebt_ulog.c
index 26377e9..bf2a333 100644
--- a/net/bridge/netfilter/ebt_ulog.c
+++ b/net/bridge/netfilter/ebt_ulog.c
@@ -216,7 +216,6 @@ unlock:
 nlmsg_failure:
 	pr_debug("error during NLMSG_PUT. This should "
 		 "not happen, please report to author.\n");
-	goto unlock;
 alloc_failure:
 	goto unlock;
 }
-- 
1.7.6


PS. Please CC me on replies since I'm not subscribed to all the lists 
copied on this mail.

-- 
Jesper Juhl <jj at chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

On Sun, 17 Jul 2011, Jesper Juhl wrote:
> In net/bridge/netfilter/ebt_ulog.c:ebt_ulog_packet() the 'goto
unlock'
> before the 'alloc_failure' label is completely redundant. This
patch
> removes it.
> 
> Signed-off-by: Jesper Juhl <jj at chaosbits.net>
> ---
>  net/bridge/netfilter/ebt_ulog.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/net/bridge/netfilter/ebt_ulog.c
b/net/bridge/netfilter/ebt_ulog.c
> index 26377e9..bf2a333 100644
> --- a/net/bridge/netfilter/ebt_ulog.c
> +++ b/net/bridge/netfilter/ebt_ulog.c
> @@ -216,7 +216,6 @@ unlock:
>  nlmsg_failure:
>  	pr_debug("error during NLMSG_PUT. This should "
>  		 "not happen, please report to author.\n");
> -	goto unlock;
>  alloc_failure:
>  	goto unlock;
>  }
> -- 
> 1.7.6
> 
> 
> PS. Please CC me on replies since I'm not subscribed to all the lists 
> copied on this mail.
Doesn't seem to be present in linux-next as of today. I have picked it up.

-- 
Jiri Kosina
SUSE Labs