Hi all,
We provid a management plattform for virtual machines (pve.proxmox.com),
and
use a bridge access the network.
Currently the system choose the lowest MAC for the purposes of STP
and also assigns this MAC to the bridge. This is a problem because the
Bridge MAC changes when we start/stop virtual machines - leading to
Network outage for several seconds.
Using the first (insteasd of lowest) MAC would avoid the problem. So are
There any side effects with the following patch?
--- br_stp_if.c.org 2008-06-11 09:15:16.000000000 +0200
+++ br_stp_if.c 2008-06-11 09:44:53.000000000 +0200
@@ -217,10 +217,7 @@
struct net_bridge_port *p;
list_for_each_entry(p, &br->port_list, list) {
- if (addr == br_mac_zero ||
- memcmp(p->dev->dev_addr, addr, ETH_ALEN) < 0)
- addr = p->dev->dev_addr;
-
+ addr = p->dev->dev_addr;
}
if (compare_ether_addr(br->bridge_id.addr, addr))
On Wed, 11 Jun 2008 10:27:54 +0200 "Dietmar Maurer" <dietmar at proxmox.com> wrote:> Hi all, > > We provid a management plattform for virtual machines (pve.proxmox.com), > and > use a bridge access the network. > > Currently the system choose the lowest MAC for the purposes of STP > and also assigns this MAC to the bridge. This is a problem because the > Bridge MAC changes when we start/stop virtual machines - leading to > Network outage for several seconds. > > Using the first (insteasd of lowest) MAC would avoid the problem. So are > > There any side effects with the following patch?Not for you. But if it got changed now, it would surprise the existing users (change in ABI behaviour). So if you need a particular mac address, you can set it with other tools (ip or ifconfig).