Yves-Alexis Perez
2018-Apr-17 15:23 UTC
[LightDM] Missing symbols in liblightdm-qt-3-0 1.26
Hi list, Robert, with the release of LightDM 1.26 I started working on updating the Debian packaging (which differs from the Ubuntu packaging) since it'll be a long-term branch. Previously in Debian we had 1.18, and I didn't bother packaging shorter term branches. The Qt library (liblightdm-qt-3-0.so) has a lot of changed symbols. Most of them are actually linked to a type change (LightDMGreeter -> _LightDMGreeter): QLightDM::GreeterPrivate::cb_authenticationComplete(LightDMGreeter*, void*)@Base QLightDM::GreeterPrivate::cb_autoLoginExpired(LightDMGreeter*, void*)@Base QLightDM::GreeterPrivate::cb_idle(LightDMGreeter*, void*)@Base QLightDM::GreeterPrivate::cb_reset(LightDMGreeter*, void*)@Base QLightDM::GreeterPrivate::cb_showMessage(LightDMGreeter*, char const*, LightDMMessageType, void*)@Base QLightDM::GreeterPrivate::cb_showPrompt(LightDMGreeter*, char const*, LightDMPromptType, void*)@Base QLightDM::UsersModelPrivate::cb_userAdded(LightDMUserList*, LightDMUser*, void*)@Base QLightDM::UsersModelPrivate::cb_userChanged(LightDMUserList*, LightDMUser*, void*)@Base QLightDM::UsersModelPrivate::cb_userRemoved(LightDMUserList*, LightDMUser*, void*)@Base Could someone comment on this? Even if the _LightDMGreeter type is internal, it's still exposed in exported symbols so it doesn't look really safe to change without bumping the soname. Some other removed symbols are: QDBusReply<QString>::~QDBusReply()@Base QDebug::~QDebug()@Base Any comment on those would be welcome too. I've attached the full diff from dpkg-gensymbols. Regards, -- Yves-Alexis -------------- next part -------------- A non-text attachment was scrubbed... Name: lightdm-1.26_liblightdm-qt-3-0.symbols.diff Type: text/x-patch Size: 5569 bytes Desc: not available URL: <https://lists.freedesktop.org/archives/lightdm/attachments/20180417/3efd53eb/attachment.bin> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: This is a digitally signed message part URL: <https://lists.freedesktop.org/archives/lightdm/attachments/20180417/3efd53eb/attachment.sig>
Yves-Alexis Perez
2018-Apr-18 07:49 UTC
[LightDM] Missing symbols in liblightdm-qt-3-0 1.26
On Tue, 2018-04-17 at 17:23 +0200, Yves-Alexis Perez wrote:> Could someone comment on this? Even if the _LightDMGreeter type is internal, > it's still exposed in exported symbols so it doesn't look really safe to > change without bumping the soname.It seems that the cb_* functions are not exposed in the headers and shouldn't be exported. Maybe it would make sense to build with -fvisibility=hidden?> > Some other removed symbols are: > > QDBusReply<QString>::~QDBusReply()@Base > QDebug::~QDebug()@Base > > Any comment on those would be welcome too.I guess those are in the same vein as the other destructors and could be marked optional? Again, confirmation would be welcome. Regards, -- Yves-Alexis -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: This is a digitally signed message part URL: <https://lists.freedesktop.org/archives/lightdm/attachments/20180418/14b406d3/attachment.sig>