On 10/30/2015 09:56 AM, Martin Vogt wrote:> > > On 10/30/2015 12:11 AM, Robert Ancell wrote: > But most likely it has to do with some opengl extensions > and is not XDMCP protocol related.Hm, I currently have a segfault. I have modified xdmcp-server with a few printf:>XDMCPPacket *packet; >g_debug ("Got n_read:%ld", n_read); >packet = xdmcp_packet_decode ((guint8 *)data, n_read); >gchar *packet_string; >packet_string = xdmcp_packet_tostring (packet); >g_debug ("Got %s", packet_string); >g_free (packet_string); >[...]>case XDMCP_ForwardQuery: >g_debug ("Before XDMCP_ForwardQuery"); >handle_forward_query (server, socket, address, packet);And i get this with "lightdm -d": [+1.74s] DEBUG: Session pid=29832: Greeter start authentication for vogt [+1.74s] DEBUG: Session pid=29852: Started with service 'lightdm', username 'vogt' [+1.76s] DEBUG: Session pid=29852: Got 1 message(s) from PAM [+1.76s] DEBUG: Session pid=29832: Prompt greeter with 1 message(s) [+22.33s] DEBUG: Got n_read:7 [+22.33s] DEBUG: Got Query(authentication_names=[]) [+22.33s] DEBUG: Got Query(authentication_names=[]) [+22.33s] DEBUG: Send Willing(authentication_name='' hostname='' status='') [+24.34s] DEBUG: Got n_read:17 [+24.34s] DEBUG: Got ForwardQuery(client_address=0A881183 client_port=D01E authentication_names=[]) [+24.34s] DEBUG: Got ForwardQuery(client_address=0A881183 client_port=D01E authentication_names=[]) [+24.34s] DEBUG: Before XDMCP_ForwardQuery [+24.34s] DEBUG: Send Willing(authentication_name='' hostname='' status='') Segmentation fault (core dumped) The thread apply all bt is most likely: Thread 1 (Thread 0x7fa354616800 (LWP 29382)): #0 0x00007fa352e08811 in __strlen_sse2_pminub () from /lib64/libc.so.6 #1 0x00007fa353ba0f73 in g_strdup () from /lib64/libglib-2.0.so.0 #2 0x0000000000422fc2 in read_cb () #3 0x00007fa354130383 in socket_source_dispatch () from /lib64/libgio-2.0.so.0 #4 0x00007fa353b8399a in g_main_context_dispatch () from /lib64/libglib-2.0.so.0 #5 0x00007fa353b83ce8 in g_main_context_iterate.isra.24 () from /lib64/libglib-2.0.so.0 #6 0x00007fa353b83fba in g_main_loop_run () from /lib64/libglib-2.0.so.0 #7 0x0000000000407d50 in main () regards, Martin
On 10/30/2015 05:31 PM, Martin Vogt wrote:> > > On 10/30/2015 09:56 AM, Martin Vogt wrote: >> >> >> On 10/30/2015 12:11 AM, Robert Ancell wrote: >> But most likely it has to do with some opengl extensions >> and is not XDMCP protocol related. > > Hm, I currently have a segfault.Found it! I seems the patch is missing a break statement and has a "fallthrought" patch: case XDMCP_ForwardQuery: handle_forward_query (server, socket, address, packet); ------> missing break case XDMCP_Request: handle_request (server, socket, address, packet); break; I added the "break;" and now it seems to work. Best regards, Martin
Thanks for the review! This change will go into the next releases. On Sat, 31 Oct 2015 at 05:51 Martin Vogt <martin.vogt at itwm.fraunhofer.de> wrote:> > > On 10/30/2015 05:31 PM, Martin Vogt wrote: > > > > > > On 10/30/2015 09:56 AM, Martin Vogt wrote: > >> > >> > >> On 10/30/2015 12:11 AM, Robert Ancell wrote: > >> But most likely it has to do with some opengl extensions > >> and is not XDMCP protocol related. > > > > Hm, I currently have a segfault. > > Found it! > I seems the patch is missing a break statement and has > a "fallthrought" > > patch: > > case XDMCP_ForwardQuery: > handle_forward_query (server, socket, address, packet); > ------> missing break > case XDMCP_Request: > handle_request (server, socket, address, packet); > break; > > > I added the "break;" and now it seems to work. > > > Best regards, > > Martin > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/lightdm/attachments/20151102/ce139eb0/attachment.html>