Robert Ancell
2015-Oct-05 20:03 UTC
[LightDM] lightdm-1.16.2 fails to build if audit is not installed
Thanks for making the patch, however this has already been fixed in LightDM 1.6.3. On Tue, 6 Oct 2015 at 09:02 Joakim Tjernlund <joakim.tjernlund at transmode.se> wrote:> A few places are missing #if HAVE_LIBAUDIT wrapped around them. > This patch fixes the build. > > --- src/session-child.c.org 2015-10-01 20:51:35.830722781 +0200 > +++ src/session-child.c 2015-10-01 20:54:09.539968600 +0200 > @@ -416,8 +416,9 @@ > ut.ut_tv.tv_usec = tv.tv_usec; > > updwtmpx ("/var/log/btmp", &ut); > - > +#if HAVE_LIBAUDIT > audit_event (AUDIT_USER_LOGIN, username, -1, > remote_host_name, tty, FALSE); > +#endif > } > > /* Check account is valid */ > @@ -733,8 +734,9 @@ > g_printerr ("Failed to write utmpx: %s\n", strerror > (errno)); > endutxent (); > updwtmpx ("/var/log/wtmp", &ut); > - > +#if HAVE_LIBAUDIT > audit_event (AUDIT_USER_LOGIN, username, uid, > remote_host_name, tty, TRUE); > +#endif > } > > waitpid (child_pid, &return_code, 0); > @@ -771,8 +773,9 @@ > g_printerr ("Failed to write utmpx: %s\n", strerror > (errno)); > endutxent (); > updwtmpx ("/var/log/wtmp", &ut); > - > +#if HAVE_LIBAUDIT > audit_event (AUDIT_USER_LOGOUT, username, uid, > remote_host_name, tty, TRUE); > +#endif > } > } > > _______________________________________________ > LightDM mailing list > LightDM at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/lightdm >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/lightdm/attachments/20151005/753e419b/attachment.html>
Joakim Tjernlund
2015-Oct-06 06:33 UTC
[LightDM] lightdm-1.16.2 fails to build if audit is not installed
On Mon, 2015-10-05 at 20:03 +0000, Robert Ancell wrote:> Thanks for making the patch, however this has already been fixed in LightDM 1.6.3.Thanks for telling me but you could have mentioned this in the release notes.> > On Tue, 6 Oct 2015 at 09:02 Joakim Tjernlund <joakim.tjernlund at transmode.se> wrote: > > A few places are missing #if HAVE_LIBAUDIT wrapped around them. > > This patch fixes the build. > > > > --- src/session-child.c.org 2015-10-01 20:51:35.830722781 +0200 > > +++ src/session-child.c 2015-10-01 20:54:09.539968600 +0200 > > @@ -416,8 +416,9 @@ > > ut.ut_tv.tv_usec = tv.tv_usec; > > > > updwtmpx ("/var/log/btmp", &ut); > > - > > +#if HAVE_LIBAUDIT > > audit_event (AUDIT_USER_LOGIN, username, -1, remote_host_name, tty, FALSE); > > +#endif > > } > > > > /* Check account is valid */ > > @@ -733,8 +734,9 @@ > > g_printerr ("Failed to write utmpx: %s\n", strerror (errno)); > > endutxent (); > > updwtmpx ("/var/log/wtmp", &ut); > > - > > +#if HAVE_LIBAUDIT > > audit_event (AUDIT_USER_LOGIN, username, uid, remote_host_name, tty, TRUE); > > +#endif > > } > > > > waitpid (child_pid, &return_code, 0); > > @@ -771,8 +773,9 @@ > > g_printerr ("Failed to write utmpx: %s\n", strerror (errno)); > > endutxent (); > > updwtmpx ("/var/log/wtmp", &ut); > > - > > +#if HAVE_LIBAUDIT > > audit_event (AUDIT_USER_LOGOUT, username, uid, remote_host_name, tty, TRUE); > > +#endif > > } > > } > > > > _______________________________________________ > > LightDM mailing list > > LightDM at lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/lightdm > >