Eric Blake
2023-Jun-09 01:18 UTC
[Libguestfs] [libnbd PATCH] maint: Tweak diff order of files under generator
When reading a diff of files used to generate other code, it helps to see API changes up front, and to see state machine changes in the order in which states are generally encountered, while leaving language binding changes for last. Signed-off-by: Eric Blake <eblake at redhat.com> --- Based on an idea here: https://listman.redhat.com/archives/libguestfs/2023-June/031716.html scripts/git.orderfile | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/scripts/git.orderfile b/scripts/git.orderfile index 89085725..5287c671 100644 --- a/scripts/git.orderfile +++ b/scripts/git.orderfile @@ -39,4 +39,16 @@ common/*/*.h # Generator files. generator/*.mli +generator/API.ml +generator/state_machine.ml +generator/states.c +generator/states-connect.c +generator/states-connect-*.c +generator/states-magic.c +generator/states-oldstyle.c +generator/states-newstyle.c +generator/states-newstyle-*.c +generator/states-issue*.c +generator/states-reply.c +generator/states-reply-*.c generator/* # Source files. -- 2.40.1
Laszlo Ersek
2023-Jun-09 12:26 UTC
[Libguestfs] [libnbd PATCH] maint: Tweak diff order of files under generator
On 6/9/23 03:18, Eric Blake wrote:> When reading a diff of files used to generate other code, it helps to > see API changes up front, and to see state machine changes in the > order in which states are generally encountered, while leaving > language binding changes for last. > > Signed-off-by: Eric Blake <eblake at redhat.com> > --- > > Based on an idea here: > https://listman.redhat.com/archives/libguestfs/2023-June/031716.html > > scripts/git.orderfile | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/scripts/git.orderfile b/scripts/git.orderfile > index 89085725..5287c671 100644 > --- a/scripts/git.orderfile > +++ b/scripts/git.orderfile > @@ -39,4 +39,16 @@ common/*/*.h > > # Generator files. > generator/*.mli > +generator/API.ml > +generator/state_machine.ml > +generator/states.c > +generator/states-connect.c > +generator/states-connect-*.c > +generator/states-magic.c > +generator/states-oldstyle.c > +generator/states-newstyle.c > +generator/states-newstyle-*.c > +generator/states-issue*.c > +generator/states-reply.c > +generator/states-reply-*.c > generator/* > > # Source files.Reviewed-by: Laszlo Ersek <lersek at redhat.com>