Laszlo Ersek
2023-Apr-18 17:26 UTC
[Libguestfs] [libnbd PATCH 18/18] ublk/tgt: wrap source code at 80 characters
Just break the initializers (for the local constant variables) to new lines, as seen elsewhere in "ublk/tgt.c" (in the context too, for example). Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=2172516 Signed-off-by: Laszlo Ersek <lersek at redhat.com> --- ublk/tgt.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ublk/tgt.c b/ublk/tgt.c index a4a4748b4c03..77d396617fb2 100644 --- a/ublk/tgt.c +++ b/ublk/tgt.c @@ -268,7 +268,8 @@ static int set_parameters (struct ublksrv_ctrl_dev *ctrl_dev, const struct ublksrv_dev *dev) { - const struct ublksrv_ctrl_dev_info *dinfo = ublksrv_ctrl_get_dev_info (ctrl_dev); + const struct ublksrv_ctrl_dev_info *dinfo + ublksrv_ctrl_get_dev_info (ctrl_dev); const unsigned attrs (readonly ? UBLK_ATTR_READ_ONLY : 0) | (rotational ? UBLK_ATTR_ROTATIONAL : 0) | @@ -308,7 +309,8 @@ set_parameters (struct ublksrv_ctrl_dev *ctrl_dev, int start_daemon (struct ublksrv_ctrl_dev *ctrl_dev) { - const struct ublksrv_ctrl_dev_info *dinfo = ublksrv_ctrl_get_dev_info (ctrl_dev); + const struct ublksrv_ctrl_dev_info *dinfo + ublksrv_ctrl_get_dev_info (ctrl_dev); const struct ublksrv_dev *dev; size_t i; int r;
Richard W.M. Jones
2023-Apr-19 10:56 UTC
[Libguestfs] [libnbd PATCH 18/18] ublk/tgt: wrap source code at 80 characters
Looks fine. I agree with Eric about "newstyle fixed", that ought not to be split. For the series: Reviewed-by: Richard W.M. Jones <rjones at redhat.com> Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW