Laszlo Ersek
2023-Mar-08 10:48 UTC
[Libguestfs] [COMMON PATCH v2 2/4] inject_virtio_win: add Virtio_SCSI to block_type
On 3/7/23 20:40, Andrey Drobyshev wrote:> Signed-off-by: Andrey Drobyshev <andrey.drobyshev at virtuozzo.com> > --- > mlcustomize/inject_virtio_win.ml | 2 +- > mlcustomize/inject_virtio_win.mli | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mlcustomize/inject_virtio_win.ml b/mlcustomize/inject_virtio_win.ml > index 8d72c5d..cf078c0 100644 > --- a/mlcustomize/inject_virtio_win.ml > +++ b/mlcustomize/inject_virtio_win.ml > @@ -51,7 +51,7 @@ type t = { > the user to select where they want to get drivers from. XXX *) > } > > -type block_type = Virtio_blk | IDE > +type block_type = Virtio_blk | Virtio_SCSI | IDE > and net_type = Virtio_net | E1000 | RTL8139 > and machine_type = I440FX | Q35 | Virt > > diff --git a/mlcustomize/inject_virtio_win.mli b/mlcustomize/inject_virtio_win.mli > index 0ced02e..58169e1 100644 > --- a/mlcustomize/inject_virtio_win.mli > +++ b/mlcustomize/inject_virtio_win.mli > @@ -20,7 +20,7 @@ > > type t (** Handle *) > > -type block_type = Virtio_blk | IDE > +type block_type = Virtio_blk | Virtio_SCSI | IDE > and net_type = Virtio_net | E1000 | RTL8139 > and machine_type = I440FX | Q35 | Virt >I seriously dislike empty commit message bodies. Please include at least a single-sentence hint there *why* this change is good. With that: Acked-by: Laszlo Ersek <lersek at redhat.com>
Andrey Drobyshev
2023-Mar-08 14:00 UTC
[Libguestfs] [COMMON PATCH v2 2/4] inject_virtio_win: add Virtio_SCSI to block_type
On 3/8/23 12:48, Laszlo Ersek wrote:> On 3/7/23 20:40, Andrey Drobyshev wrote: >> Signed-off-by: Andrey Drobyshev <andrey.drobyshev at virtuozzo.com> >> --- >> mlcustomize/inject_virtio_win.ml | 2 +- >> mlcustomize/inject_virtio_win.mli | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/mlcustomize/inject_virtio_win.ml b/mlcustomize/inject_virtio_win.ml >> index 8d72c5d..cf078c0 100644 >> --- a/mlcustomize/inject_virtio_win.ml >> +++ b/mlcustomize/inject_virtio_win.ml >> @@ -51,7 +51,7 @@ type t = { >> the user to select where they want to get drivers from. XXX *) >> } >> >> -type block_type = Virtio_blk | IDE >> +type block_type = Virtio_blk | Virtio_SCSI | IDE >> and net_type = Virtio_net | E1000 | RTL8139 >> and machine_type = I440FX | Q35 | Virt >> >> diff --git a/mlcustomize/inject_virtio_win.mli b/mlcustomize/inject_virtio_win.mli >> index 0ced02e..58169e1 100644 >> --- a/mlcustomize/inject_virtio_win.mli >> +++ b/mlcustomize/inject_virtio_win.mli >> @@ -20,7 +20,7 @@ >> >> type t (** Handle *) >> >> -type block_type = Virtio_blk | IDE >> +type block_type = Virtio_blk | Virtio_SCSI | IDE >> and net_type = Virtio_net | E1000 | RTL8139 >> and machine_type = I440FX | Q35 | Virt >> > > I seriously dislike empty commit message bodies. Please include at least > a single-sentence hint there *why* this change is good. > > With that: > > Acked-by: Laszlo Ersek <lersek at redhat.com> >Sure, thanks for pointing out. Will do as soon as Richard leaves his notes on the series.
Richard W.M. Jones
2023-Mar-08 14:01 UTC
[Libguestfs] [COMMON PATCH v2 2/4] inject_virtio_win: add Virtio_SCSI to block_type
On Wed, Mar 08, 2023 at 04:00:10PM +0200, Andrey Drobyshev wrote:> Sure, thanks for pointing out. Will do as soon as Richard leaves his > notes on the series.I'm giving a talk this afternoon, but I should be able to look at it later. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org