I approved PR 21. But I'd like to merge PR 19 too, to fix the Cirrus CI that runs on the Github mirror. On Fri, Jan 13, 2023 at 11:03 AM Richard W.M. Jones <rjones at redhat.com> wrote:> > On Fri, Jan 13, 2023 at 06:00:07PM +0000, Richard W.M. Jones wrote: > > I'll push something to PR#19 in a few mins. > > Actually I don't think I can modify it, so I opened an alternate PR: > > https://gitlab.com/nbdkit/nbdkit/-/merge_requests/21 > > Rich. > > -- > Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones > Read my programming and virtualization blog: http://rwmj.wordpress.com > virt-builder quickly builds VMs from scratch > http://libguestfs.org/virt-builder.1.html >
Richard W.M. Jones
2023-Jan-13 18:24 UTC
[Libguestfs] Cargo edition problem with Debian 11
On Fri, Jan 13, 2023 at 11:18:10AM -0700, alan somers wrote:> I approved PR 21. But I'd like to merge PR 19 too, to fix the Cirrus > CI that runs on the Github mirror.Sure thing! Please go ahead, as I'm going to wait for PR21 to see exactly what tests still fail. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
Richard W.M. Jones
2023-Jan-13 18:34 UTC
[Libguestfs] Cargo edition problem with Debian 11
> https://github.com/libguestfs/nbdkit/pull/19Actually I suspect that the changes made in PR19 will get overwritten since they touch files which are in git but are really controlled by libvirt-ci. I'm not sure how to make the changes in a way which are compatible with libvirt-ci, maybe Eric or others can help with that. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html