Richard W.M. Jones
2023-Jan-07 19:44 UTC
[Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]
This is upstream in nbdkit now: https://gitlab.com/nbdkit/nbdkit/-/tree/master/plugins/blkio Another question: (6) vhost-user + "read-only" property acts a bit strangely. After opening virtio-blk-vhost-user it throws an EROFS error if you try to "blkio_start" it. However if you set the "read-only" property to true then it's OK to start it, and subsequent read operations work too. I would expect that any device can be started without needing to set this property, and in general I don't understand why vhost-user is r/o since everything I read about it seems to indicate it's a general purpose writable protocol. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
Stefan Hajnoczi
2023-Jan-11 16:34 UTC
[Libguestfs] [PATCH nbdkit] New plugin: blkio [incomplete]
On Sat, Jan 07, 2023 at 07:44:37PM +0000, Richard W.M. Jones wrote:> > This is upstream in nbdkit now: > https://gitlab.com/nbdkit/nbdkit/-/tree/master/plugins/blkio > > Another question: > > (6) vhost-user + "read-only" property acts a bit strangely. After > opening virtio-blk-vhost-user it throws an EROFS error if you try to > "blkio_start" it. However if you set the "read-only" property to true > then it's OK to start it, and subsequent read operations work too. > > I would expect that any device can be started without needing to set > this property, and in general I don't understand why vhost-user is r/o > since everything I read about it seems to indicate it's a general > purpose writable protocol.I guess the vhost-user-blk server is read-only and that's why it's refusing to blkio_start() unless readonly was set to true. If you're using qemu-storage-daemon, set the writable=on parameter on the export. Stefan -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://listman.redhat.com/archives/libguestfs/attachments/20230111/a91e5af6/attachment.sig>