(this reproduces at commit 0687cea6a86e; IOW the regression is not from the recent GTK-related patches, but due to building p2v with GTK3. as opposed to GTK2) In the first dialog, when the Test Connection button is clicked, a spinner is supposed to be shown to the left, while p2v communicates via v2v over ssh. This spinner is seen when running virt-p2v directly, but not when running virt-p2v from a VM (using either a Live CD, or the "run-virt-p2v-in-a-vm" makefile target). This difference is not seen when virt-p2v is built with GTK2; in that case, *both* scenarios (direct & VM) show the spinner properly. I don't have an idea what the cause is. I vaguely suspect it could be related to the windowing environment (window manager) in use. It pretty much looks like a GTK3 bug to me; whatever the windowing environment, the spinner should either be there or not. (It's possible that we have a virt-p2v bug, of course, but why isn't the symptom consistent then? GTK3 should not have a dependency at all on the Window Manager.) Laszlo
On Wed, Sep 28, 2022 at 02:01:11PM +0200, Laszlo Ersek wrote:> (this reproduces at commit 0687cea6a86e; IOW the regression is not from > the recent GTK-related patches, but due to building p2v with GTK3. as > opposed to GTK2) > > In the first dialog, when the Test Connection button is clicked, a > spinner is supposed to be shown to the left, while p2v communicates via > v2v over ssh. This spinner is seen when running virt-p2v directly, but > not when running virt-p2v from a VM (using either a Live CD, or the > "run-virt-p2v-in-a-vm" makefile target).I can see the spinner when running locally. After hacking Makefile.am so it builds the VM with fedora-36 (I'm actually using Fedora 37 and there is no virt-builder template), I was able to do 'make run-virt-p2v-in-a-vm', and I _did_ see the spinner there too. No idea why it works for me and not for you.> This difference is not seen when virt-p2v is built with GTK2; in that > case, *both* scenarios (direct & VM) show the spinner properly. > > I don't have an idea what the cause is. I vaguely suspect it could be > related to the windowing environment (window manager) in use. It pretty > much looks like a GTK3 bug to me; whatever the windowing environment, > the spinner should either be there or not. (It's possible that we have a > virt-p2v bug, of course, but why isn't the symptom consistent then? GTK3 > should not have a dependency at all on the Window Manager.)On my laptop: gtk3-3.24.34-2.fc37.x86_64 Inside the p2v VM: gtk3-3.24.34-1.fc36.x86_64 Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
On Wed, Sep 28, 2022 at 02:01:11PM +0200, Laszlo Ersek wrote:> (this reproduces at commit 0687cea6a86e; IOW the regression is not from > the recent GTK-related patches, but due to building p2v with GTK3. as > opposed to GTK2) > > In the first dialog, when the Test Connection button is clicked, a > spinner is supposed to be shown to the left, while p2v communicates via > v2v over ssh. This spinner is seen when running virt-p2v directly, but > not when running virt-p2v from a VM (using either a Live CD, or the > "run-virt-p2v-in-a-vm" makefile target). > > This difference is not seen when virt-p2v is built with GTK2; in that > case, *both* scenarios (direct & VM) show the spinner properly. > > I don't have an idea what the cause is. I vaguely suspect it could be > related to the windowing environment (window manager) in use. It pretty > much looks like a GTK3 bug to me; whatever the windowing environment, > the spinner should either be there or not. (It's possible that we have a > virt-p2v bug, of course, but why isn't the symptom consistent then? GTK3 > should not have a dependency at all on the Window Manager.)There certainly are dependancies on both the window manager, and the desktop system (X11 vs wayland). There's a huge set of features that widget toolkits can negotiate with window managers, and each window manager supports a different set of extensions, just one example being support for client side window decorations. In theory GTK should adapt to expose the same functionality to users whereever possible but there are certainly edge cases where this doesn't work, and bugs will certainly be present for more obscure combinations like X11 + any non mainstream window manager. It is also not surprising to see a differnce from GTK2 to 3, as it radically changed under the hood, most notably with native Wayland support. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|