On Mon, Mar 14, 2022 at 09:18:04AM +0000, Daniel P. Berrang? wrote:> On Sat, Mar 12, 2022 at 10:50:21AM +0000, Richard W.M. Jones wrote: > > Am I doing this wrong? [see log below] This is using the upstream > > libvirt-ci checked out just now from gitlab, but it seems as if nbdkit > > has to be listed as a project under that repo. > > > > "./lcitool projects" shows libnbd but not nbdkit. > > Indeed, there's only libnbd there. Presumably nbdkit is something > Martin hasn't got around to adding ? > > With recentish changes though there's no longer any need to add > projects directly to libvirt-ci.git. They can be kept locally > in the project eg > > nbdkit.git/ci/projects/nbdkit.yml > > then use 'lcitool --data-dir ci' and it'll find the nbdkit.yml > when searching for projects. > > libvirt-ci.git will only need modifying it distro package > mappings need additions/changes.I copied libvirt-ci.git/guests/lcitool/lcitool/ansible/vars/projects/libnbd.yml to ci/projects/nbdkit.yml. I'll probably have to adjust the packages in that file, but it did allow me to re-run the command above and regenerate the templates. Martin - I guess you must have created that nbdkit.yml file at some point, but I can't find it in your fork.> > A second question, since the libvirt-ci project does a bunch of stuff > > with ansible & containers, regenerating the files like this doesn't > > require ansible & containers? (I don't want to run those on my > > development machine.) > > ansible is only used when managing VMs, no need for it with containers.I meant would the "manifest" subcommand do anything weird (ie. not just updating the templates), but it seems fine. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
On Mon, Mar 14, 2022 at 10:01:46AM +0000, Richard W.M. Jones wrote:> On Mon, Mar 14, 2022 at 09:18:04AM +0000, Daniel P. Berrang? wrote: > > On Sat, Mar 12, 2022 at 10:50:21AM +0000, Richard W.M. Jones wrote: > > > Am I doing this wrong? [see log below] This is using the upstream > > > libvirt-ci checked out just now from gitlab, but it seems as if nbdkit > > > has to be listed as a project under that repo. > > > > > > "./lcitool projects" shows libnbd but not nbdkit. > > > > Indeed, there's only libnbd there. Presumably nbdkit is something > > Martin hasn't got around to adding ? > > > > With recentish changes though there's no longer any need to add > > projects directly to libvirt-ci.git. They can be kept locally > > in the project eg > > > > nbdkit.git/ci/projects/nbdkit.yml > > > > then use 'lcitool --data-dir ci' and it'll find the nbdkit.yml > > when searching for projects. > > > > libvirt-ci.git will only need modifying it distro package > > mappings need additions/changes. > > I copied libvirt-ci.git/guests/lcitool/lcitool/ansible/vars/projects/libnbd.yml > to ci/projects/nbdkit.yml. I'll probably have to adjust the packages > in that file, but it did allow me to re-run the command above and > regenerate the templates. > > Martin - I guess you must have created that nbdkit.yml file at some > point, but I can't find it in your fork. > > > > A second question, since the libvirt-ci project does a bunch of stuff > > > with ansible & containers, regenerating the files like this doesn't > > > require ansible & containers? (I don't want to run those on my > > > development machine.) > > > > ansible is only used when managing VMs, no need for it with containers. > > I meant would the "manifest" subcommand do anything weird (ie. not > just updating the templates), but it seems fine.Yep, the manifest command doesn't do anything with VMs or ansible. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Mon, Mar 14, 2022 at 10:01:46AM +0000, Richard W.M. Jones wrote:> Martin - I guess you must have created that nbdkit.yml file at some > point, but I can't find it in your fork.Found it: https://gitlab.com/nertpinx/libvirt-ci/-/commits/_nbdkit2 I guess we're still missing almalinux support in libvirt-ci though. $ ../libvirt-ci/lcitool manifest ci/manifest.yml [ERROR]: An unexpected error occurred Traceback (most recent call last): File "/home/rjones/d/libvirt-ci/guests/lcitool/lcitool/manifest.py", line 87, in _normalize facts = inventory.target_facts[target] KeyError: 'almalinux-8' Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/