Richard W.M. Jones
2022-Jan-17 13:21 UTC
[Libguestfs] [PATCH v2v] docs: Remove mention of direct backend / bug 1140166
Commit 2c91610ab3 ("v2v/input_libvirt_xen_ssh.ml: Remove obsolete
error check.") was incomplete. We no longer need to use the direct
backend to work around bug 1140166, because we use nbdkit + the ssh
plugin instead of qemu's ssh backend. The manual page still mentioned
this.
Fixes: commit 2c91610ab35ad1e8b49596bcaa94731c67031180
Thanks: Xiaodai Wang, Laszlo Ersek
---
docs/virt-v2v-input-xen.pod | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/docs/virt-v2v-input-xen.pod b/docs/virt-v2v-input-xen.pod
index cd3210bf67..857a70956f 100644
--- a/docs/virt-v2v-input-xen.pod
+++ b/docs/virt-v2v-input-xen.pod
@@ -4,7 +4,6 @@ virt-v2v-input-xen - Using virt-v2v to convert guests from Xen
=head1 SYNOPSIS
- export LIBGUESTFS_BACKEND=direct
virt-v2v -ic 'xen+ssh://root at xen.example.com'
-ip passwordfile
GUEST_NAME [-o* options]
@@ -69,8 +68,7 @@ below for a workaround.
To import a particular guest from a Xen server, do:
- $ LIBGUESTFS_BACKEND=direct \
- virt-v2v -ic 'xen+ssh://root at xen.example.com' \
+ $ virt-v2v -ic 'xen+ssh://root at xen.example.com' \
rhel49-x86_64-pv \
-o local -os /var/tmp
@@ -81,10 +79,6 @@ In this case the output flags are set to write the converted
guest to
a temporary directory as this is just an example, but you can also
write to libvirt or any other supported target.
-Setting the L<backend|guestfs(3)/BACKEND> to C<direct> is a
temporary
-workaround until
-L<libvirt bug 1140166|https://bugzilla.redhat.com/1140166> is fixed.
-
=head2 Xen or ssh conversions from block devices
Currently virt-v2v cannot directly access a Xen guest (or any guest
--
2.32.0
Laszlo Ersek
2022-Jan-17 15:45 UTC
[Libguestfs] [PATCH v2v] docs: Remove mention of direct backend / bug 1140166
On 01/17/22 14:21, Richard W.M. Jones wrote:> Commit 2c91610ab3 ("v2v/input_libvirt_xen_ssh.ml: Remove obsolete > error check.") was incomplete. We no longer need to use the direct > backend to work around bug 1140166, because we use nbdkit + the ssh > plugin instead of qemu's ssh backend. The manual page still mentioned > this. > > Fixes: commit 2c91610ab35ad1e8b49596bcaa94731c67031180 > Thanks: Xiaodai Wang, Laszlo Ersek > --- > docs/virt-v2v-input-xen.pod | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/docs/virt-v2v-input-xen.pod b/docs/virt-v2v-input-xen.pod > index cd3210bf67..857a70956f 100644 > --- a/docs/virt-v2v-input-xen.pod > +++ b/docs/virt-v2v-input-xen.pod > @@ -4,7 +4,6 @@ virt-v2v-input-xen - Using virt-v2v to convert guests from Xen > > =head1 SYNOPSIS > > - export LIBGUESTFS_BACKEND=direct > virt-v2v -ic 'xen+ssh://root at xen.example.com' > -ip passwordfile > GUEST_NAME [-o* options] > @@ -69,8 +68,7 @@ below for a workaround. > > To import a particular guest from a Xen server, do: > > - $ LIBGUESTFS_BACKEND=direct \ > - virt-v2v -ic 'xen+ssh://root at xen.example.com' \ > + $ virt-v2v -ic 'xen+ssh://root at xen.example.com' \ > rhel49-x86_64-pv \ > -o local -os /var/tmp > > @@ -81,10 +79,6 @@ In this case the output flags are set to write the converted guest to > a temporary directory as this is just an example, but you can also > write to libvirt or any other supported target. > > -Setting the L<backend|guestfs(3)/BACKEND> to C<direct> is a temporary > -workaround until > -L<libvirt bug 1140166|https://bugzilla.redhat.com/1140166> is fixed. > - > =head2 Xen or ssh conversions from block devices > > Currently virt-v2v cannot directly access a Xen guest (or any guest >Reviewed-by: Laszlo Ersek <lersek at redhat.com>