Richard W.M. Jones
2022-Jan-11 11:22 UTC
[Libguestfs] [v2v PATCH] convert/libosinfo-c.c: turn caml_copy_*() return blocks into root values
On Tue, Jan 11, 2022 at 12:15:13PM +0100, Laszlo Ersek wrote:> By the way, we have more "offenders" left: > > - three in "bundled/libvirt-ocaml/libvirt_c_common.c":I'm quite sure this happens in a lot of places. BTW libvirt-ocaml is a separate project, so fixes should go to: https://libvirt.org/git/?p=libvirt-ocaml.git;a=summary (and really we should remove all bundled code - I can't recall why it was added, but it's not needed now.)> I guess those need to be modified in the libvirt-ocaml project first.Yup. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW
Laszlo Ersek
2022-Jan-12 11:13 UTC
[Libguestfs] [v2v PATCH] convert/libosinfo-c.c: turn caml_copy_*() return blocks into root values
On 01/11/22 12:22, Richard W.M. Jones wrote:> On Tue, Jan 11, 2022 at 12:15:13PM +0100, Laszlo Ersek wrote: >> By the way, we have more "offenders" left: >> >> - three in "bundled/libvirt-ocaml/libvirt_c_common.c": > > I'm quite sure this happens in a lot of places. > > BTW libvirt-ocaml is a separate project, so fixes should go to: > > https://libvirt.org/git/?p=libvirt-ocaml.git;a=summaryWhat is the best place to report a bug for this? Libvir-list perhaps? Thanks! Laszlo> > (and really we should remove all bundled code - I can't recall why it > was added, but it's not needed now.) > >> I guess those need to be modified in the libvirt-ocaml project first. > > Yup. > > Rich. >
Daniel P. Berrangé
2022-Jan-12 11:26 UTC
[Libguestfs] [v2v PATCH] convert/libosinfo-c.c: turn caml_copy_*() return blocks into root values
On Tue, Jan 11, 2022 at 11:22:56AM +0000, Richard W.M. Jones wrote:> On Tue, Jan 11, 2022 at 12:15:13PM +0100, Laszlo Ersek wrote: > > By the way, we have more "offenders" left: > > > > - three in "bundled/libvirt-ocaml/libvirt_c_common.c": > > I'm quite sure this happens in a lot of places. > > BTW libvirt-ocaml is a separate project, so fixes should go to: > > https://libvirt.org/git/?p=libvirt-ocaml.git;a=summary > > (and really we should remove all bundled code - I can't recall why it > was added, but it's not needed now.)NB that's a read-only mirror, the primary repo is: https://gitlab.com/libvirt/libvirt-ocaml/ and takes patches via merge requests Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|