Laszlo Ersek
2022-Jan-07 10:24 UTC
[Libguestfs] [v2v PATCH 9/9] convert: determine machine type and virtio-1.0 from osinfo for x86 guests
On 01/07/22 11:21, Laszlo Ersek wrote:> On 01/06/22 16:10, Richard W.M. Jones wrote: >> >> This one looks fine, ACK >> >> No need to post v2. Fix anything I noted if you want. >> >> It'd be nice to get this into RHEL 9 by the end of this week. If you >> can push it later today or tomorrow then I can add it. Coincidentally >> I was just doing a RHEL 9 release right this moment, but I won't >> continue with that for now. > > I'd like you to please advise me some more under patch#6, then I'll go > ahead and merge the thing still today.Oh I'm sorry I see your message is from 6 Jan, and tag v1.45.96 is also from yesterday -- so is it still helpful if I merge this today? Thanks, Laszlo
Richard W.M. Jones
2022-Jan-07 10:58 UTC
[Libguestfs] [v2v PATCH 9/9] convert: determine machine type and virtio-1.0 from osinfo for x86 guests
On Fri, Jan 07, 2022 at 11:24:14AM +0100, Laszlo Ersek wrote:> On 01/07/22 11:21, Laszlo Ersek wrote: > > On 01/06/22 16:10, Richard W.M. Jones wrote: > >> > >> This one looks fine, ACK > >> > >> No need to post v2. Fix anything I noted if you want. > >> > >> It'd be nice to get this into RHEL 9 by the end of this week. If you > >> can push it later today or tomorrow then I can add it. Coincidentally > >> I was just doing a RHEL 9 release right this moment, but I won't > >> continue with that for now. > > > > I'd like you to please advise me some more under patch#6, then I'll go > > ahead and merge the thing still today. > > Oh I'm sorry I see your message is from 6 Jan, and tag v1.45.96 is also > from yesterday -- so is it still helpful if I merge this today?If possible, yes. At the moment I'm doing some time-consuming benchmarking of v2v (more on that later) so it's not a problem if it doesn't get in today. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html