Laszlo Ersek
2021-Dec-15 14:01 UTC
[Libguestfs] [v2v PATCH] test-v2v-o-libvirt: undefine temporary guest when exiting
I've noticed that my libvirtd host that I use for v2v development is littered with tmp-* guests. Re-enable the "virsh undefine" command. Signed-off-by: Laszlo Ersek <lersek at redhat.com> --- tests/test-v2v-o-libvirt.sh | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/test-v2v-o-libvirt.sh b/tests/test-v2v-o-libvirt.sh index 7396b2ad69b2..d44f55dd6feb 100755 --- a/tests/test-v2v-o-libvirt.sh +++ b/tests/test-v2v-o-libvirt.sh @@ -55,8 +55,7 @@ rm -rf $d # Clean up. cleanup_fn rm -r $d cleanup_fn virsh pool-destroy $poolname -# I think because the pool is transient, this is not necessary: -#cleanup_fn virsh undefine $guestname +cleanup_fn virsh undefine $guestname mkdir $d -- 2.19.1.3.g30247aa5d201
Richard W.M. Jones
2021-Dec-16 09:13 UTC
[Libguestfs] [v2v PATCH] test-v2v-o-libvirt: undefine temporary guest when exiting
On Wed, Dec 15, 2021 at 03:01:27PM +0100, Laszlo Ersek wrote:> I've noticed that my libvirtd host that I use for v2v development is > littered with tmp-* guests. Re-enable the "virsh undefine" command. > > Signed-off-by: Laszlo Ersek <lersek at redhat.com> > --- > tests/test-v2v-o-libvirt.sh | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tests/test-v2v-o-libvirt.sh b/tests/test-v2v-o-libvirt.sh > index 7396b2ad69b2..d44f55dd6feb 100755 > --- a/tests/test-v2v-o-libvirt.sh > +++ b/tests/test-v2v-o-libvirt.sh > @@ -55,8 +55,7 @@ rm -rf $d > # Clean up. > cleanup_fn rm -r $d > cleanup_fn virsh pool-destroy $poolname > -# I think because the pool is transient, this is not necessary: > -#cleanup_fn virsh undefine $guestname > +cleanup_fn virsh undefine $guestname > > mkdir $dYes, not sure why I deleted that, but I notice the same thing happening. ACK Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://people.redhat.com/~rjones/virt-df/