Libguestfs - Dec 2021 - [PATCH libnbd CI] ci: Drop Fedora 33, add Fedora 35

On Mon, Dec 13, 2021 at 02:40:40PM +0000, Richard W.M. Jones
wrote:
>
>I pushed this (commit 202d0ecad) in the hope it might fix the tests.
>However Martin indicates that the error message might be nothing to do
>with the Fedora version.  Let's see.
>
It looks like everything went swimmingly the next time around even
before this patch:

https://gitlab.com/nbdkit/libnbd/-/pipelines/428406657

so it clear wasn't anything with Fedora 33, although updating to F35 is
definitely worth doing.

It did not happen to be before here with the containers for libnbd.  I
guess it can happen any time if there is an issue on the remote side
when pushing a container for example.

However I am facing few issues with nbdkit CI that I am still trying to
finish and on and off working on it.  The issue there is that the tests
time out because of all the qemu invocations, especially with TCG.  I am
trying to think about what tests to skip and maybe split the load
between different distros.

That's just something I wanted to mention because it still keeps me up
at nights while I cannot get out of the loop of finding out why test
gets skipped, then either fixing the test or figuring out the missing
package name for all distros to properly update libvirt-ci's
mapping.yaml, and then looking at what next tests are failing or getting
skipped and why.
>Rich.
>
>-- 
>Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
>Read my programming and virtualization blog: http://rwmj.wordpress.com
>virt-top is 'top' for virtual machines.  Tiny program with many
>powerful monitoring features, net stats, disk stats, logging, etc.
>http://people.redhat.com/~rjones/virt-top
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20211213/91670fe3/attachment.sig>

On Mon, Dec 13, 2021 at 04:07:27PM +0100, Martin Kletzander
wrote:
> On Mon, Dec 13, 2021 at 02:40:40PM +0000, Richard W.M. Jones wrote:
> >
> >I pushed this (commit 202d0ecad) in the hope it might fix the tests.
> >However Martin indicates that the error message might be nothing to do
> >with the Fedora version.  Let's see.
> >
> 
> It looks like everything went swimmingly the next time around even
> before this patch:
> 
> https://gitlab.com/nbdkit/libnbd/-/pipelines/428406657
Yes, it does look like a temporary docker pull problem.
> so it clear wasn't anything with Fedora 33, although updating to F35 is
> definitely worth doing.
Yup.
> It did not happen to be before here with the containers for libnbd.  I
> guess it can happen any time if there is an issue on the remote side
> when pushing a container for example.
> 
> However I am facing few issues with nbdkit CI that I am still trying to
> finish and on and off working on it.  The issue there is that the tests
> time out because of all the qemu invocations, especially with TCG.  I am
> trying to think about what tests to skip and maybe split the load
> between different distros.
So you can disable the libguestfs-based tests if TCG is too slow:

https://src.fedoraproject.org/rpms/nbdkit/blob/rawhide/f/nbdkit.spec#_695

We probably ought to formalise that into a configure flag, but at the
moment the above trick should be reliable because we use the same in
Fedora builds on slow arches.

Also re nbdkit CI, it turns out Windows builds were broken for a while
(I fixed it a few days ago).  Would be nice to CI this!

https://gitlab.com/nbdkit/nbdkit/-/issues/3
> That's just something I wanted to mention because it still keeps me up
> at nights while I cannot get out of the loop of finding out why test
> gets skipped, then either fixing the test or figuring out the missing
> package name for all distros to properly update libvirt-ci's
> mapping.yaml, and then looking at what next tests are failing or getting
> skipped and why.
:-)

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/

On Mon, Dec 13, 2021 at 03:17:56PM +0000, Richard W.M. Jones
wrote:
> So you can disable the libguestfs-based tests if TCG is too slow:
> 
> https://src.fedoraproject.org/rpms/nbdkit/blob/rawhide/f/nbdkit.spec#_695
> 
> We probably ought to formalise that into a configure flag, but at the
> moment the above trick should be reliable because we use the same in
> Fedora builds on slow arches.
https://gitlab.com/nbdkit/nbdkit/-/commit/c09ae98ff3b4b786565de4aa173274531a

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html