Laszlo Ersek
2021-Nov-23 12:29 UTC
[Libguestfs] [PATCH] xfs: Document lazy-counters setting cannot be changed in XFS version 5
On 11/22/21 16:11, Richard W.M. Jones wrote:> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2024022 > --- > generator/actions_core.ml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/generator/actions_core.ml b/generator/actions_core.ml > index 5933282dcf..226fb860a0 100644 > --- a/generator/actions_core.ml > +++ b/generator/actions_core.ml > @@ -7665,7 +7665,10 @@ can modify parameters. > > Some of the parameters of a mounted filesystem can be examined > and modified using the C<guestfs_xfs_info> and > -C<guestfs_xfs_growfs> calls." }; > +C<guestfs_xfs_growfs> calls. > + > +Beginning with XFS version 5, it is no longer possible to modify > +the lazy-counters setting (ie. C<lazycounter> parameter has no effect)." }; > > { defaults with > name = "xfs_repair"; added = (1, 19, 36); >Acked-by: Laszlo Ersek <lersek at redhat.com>
Richard W.M. Jones
2021-Nov-23 13:06 UTC
[Libguestfs] [PATCH] xfs: Document lazy-counters setting cannot be changed in XFS version 5
On Tue, Nov 23, 2021 at 01:29:14PM +0100, Laszlo Ersek wrote:> On 11/22/21 16:11, Richard W.M. Jones wrote: > > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2024022 > > --- > > generator/actions_core.ml | 5 ++++- > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/generator/actions_core.ml b/generator/actions_core.ml > > index 5933282dcf..226fb860a0 100644 > > --- a/generator/actions_core.ml > > +++ b/generator/actions_core.ml > > @@ -7665,7 +7665,10 @@ can modify parameters. > > > > Some of the parameters of a mounted filesystem can be examined > > and modified using the C<guestfs_xfs_info> and > > -C<guestfs_xfs_growfs> calls." }; > > +C<guestfs_xfs_growfs> calls. > > + > > +Beginning with XFS version 5, it is no longer possible to modify > > +the lazy-counters setting (ie. C<lazycounter> parameter has no effect)." }; > > > > { defaults with > > name = "xfs_repair"; added = (1, 19, 36); > > > > Acked-by: Laszlo Ersek <lersek at redhat.com>Thanks, pushed it as: e7f72ab146b9c2aaee92a600a1fcbefb0202d41c forgot to add the Acked-by though :-( Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html