Richard W.M. Jones
2021-Sep-08 15:49 UTC
[Libguestfs] [hivex PATCH 8/8] build: allow OCaml programs using hivex to be compiled against build dir
Yes the series looks fine, ACK series. I think the presence of $(top_builddir)/lib to look for the header file was likely a copy-paste thing from some other project. The generator always writes files into the source directory (or if you build from the tarball, everything is already in the source directory.) Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org
Laszlo Ersek
2021-Sep-09 10:42 UTC
[Libguestfs] [hivex PATCH 8/8] build: allow OCaml programs using hivex to be compiled against build dir
On 09/08/21 17:49, Richard W.M. Jones wrote:> > Yes the series looks fine, ACK series.Thanks!> I think the presence of $(top_builddir)/lib to look for the header > file was likely a copy-paste thing from some other project. The > generator always writes files into the source directory (or if you > build from the tarball, everything is already in the source directory.)Right, I'd not been familiar with autotools internals, so I first needed to understand that the generator ran during autogen, and (therefore) its output would be included by "make dist" in the *source* tree. Thanks! Laszlo