Richard W.M. Jones
2021-Aug-24 16:06 UTC
[Libguestfs] [PATCH nbdkit v4] tests: Remove $libdir from LD_PRELOAD arg
It turns out that LD_PRELOAD already searches the path and that's
going to be far more reliable than using $libdir.
Fixes: commit 8972831aa2a32d4b5820465d37c1827eb76450e4
Fixes: commit 362e0fdcae37db876e13b944102a5c152e6bc563
---
tests/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 35b2e4a6..f8af70c5 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -76,7 +76,7 @@ TESTS_ENVIRONMENT = \
random = $(shell bash -c 'echo $$(( 1 + (RANDOM & 255) ))')
if HAVE_GLIBC_234
TESTS_ENVIRONMENT += \
-
LD_PRELOAD="$${LD_PRELOAD:+"$$LD_PRELOAD:"}$(libdir)/libc_malloc_debug.so.0"
\
+
LD_PRELOAD="$${LD_PRELOAD:+"$$LD_PRELOAD:"}libc_malloc_debug.so.0"
\
GLIBC_TUNABLES=glibc.malloc.check=1:glibc.malloc.perturb=$(random) \
$(NULL)
else
--
2.32.0
Eric Blake
2021-Aug-25 18:21 UTC
[Libguestfs] [PATCH nbdkit v4] tests: Remove $libdir from LD_PRELOAD arg
On Tue, Aug 24, 2021 at 05:06:29PM +0100, Richard W.M. Jones wrote:> It turns out that LD_PRELOAD already searches the path and that's > going to be far more reliable than using $libdir. > > Fixes: commit 8972831aa2a32d4b5820465d37c1827eb76450e4 > Fixes: commit 362e0fdcae37db876e13b944102a5c152e6bc563 > --- > tests/Makefile.am | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)ACK -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org