Martin Kletzander
2021-Aug-23 12:46 UTC
[Libguestfs] [libnbd PATCH] ci: Do not run valgrind checks
Since valgrind checks find unrelated issues it spoils the CI effort and makes us
ignore the output in the long run. If we want we can turn on valgrind checks
for one or two particular platforms by setting "CHECK_VALGRIND" to
"force".
Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
.gitlab-ci.yml | 3 ---
ci/build.sh | 2 +-
2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 60c8097d32bc..22e732b184d9 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -249,7 +249,6 @@ x64-opensuse-leap-152:
- x64-opensuse-leap-152-container
variables:
NAME: opensuse-leap-152
- CHECK_VALGRIND: skip
x64-opensuse-tumbleweed:
extends: .native_build_job
@@ -257,7 +256,6 @@ x64-opensuse-tumbleweed:
- x64-opensuse-tumbleweed-container
variables:
NAME: opensuse-tumbleweed
- CHECK_VALGRIND: skip
x64-ubuntu-1804:
extends: .native_build_job
@@ -273,7 +271,6 @@ x64-ubuntu-2004:
- x64-ubuntu-2004-container
variables:
NAME: ubuntu-2004
- CHECK_VALGRIND: skip
x64-freebsd-12-build:
extends: .cirrus_build_job
diff --git a/ci/build.sh b/ci/build.sh
index 2811fc4535f2..8ee4a87ea9b7 100755
--- a/ci/build.sh
+++ b/ci/build.sh
@@ -103,7 +103,7 @@ main() {
run_checks check
- if test "$CHECK_VALGRIND" != "skip"
+ if test "$CHECK_VALGRIND" = "force"
then
run_checks check-valgrind
fi
--
2.32.0
Richard W.M. Jones
2021-Aug-23 13:12 UTC
[Libguestfs] [libnbd PATCH] ci: Do not run valgrind checks
On Mon, Aug 23, 2021 at 02:46:38PM +0200, Martin Kletzander wrote:> Since valgrind checks find unrelated issues it spoils the CI effort and makes us > ignore the output in the long run. If we want we can turn on valgrind checks > for one or two particular platforms by setting "CHECK_VALGRIND" to "force".Yeah I agree, no need to run valgrind tests in CI as they are very fragile. They really are only guaranteed to work on _my_ computer, maybe Eric's too on a good day! ACK Rich.> Signed-off-by: Martin Kletzander <mkletzan at redhat.com> > --- > .gitlab-ci.yml | 3 --- > ci/build.sh | 2 +- > 2 files changed, 1 insertion(+), 4 deletions(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 60c8097d32bc..22e732b184d9 100644 > --- a/.gitlab-ci.yml > +++ b/.gitlab-ci.yml > @@ -249,7 +249,6 @@ x64-opensuse-leap-152: > - x64-opensuse-leap-152-container > variables: > NAME: opensuse-leap-152 > - CHECK_VALGRIND: skip > > x64-opensuse-tumbleweed: > extends: .native_build_job > @@ -257,7 +256,6 @@ x64-opensuse-tumbleweed: > - x64-opensuse-tumbleweed-container > variables: > NAME: opensuse-tumbleweed > - CHECK_VALGRIND: skip > > x64-ubuntu-1804: > extends: .native_build_job > @@ -273,7 +271,6 @@ x64-ubuntu-2004: > - x64-ubuntu-2004-container > variables: > NAME: ubuntu-2004 > - CHECK_VALGRIND: skip > > x64-freebsd-12-build: > extends: .cirrus_build_job > diff --git a/ci/build.sh b/ci/build.sh > index 2811fc4535f2..8ee4a87ea9b7 100755 > --- a/ci/build.sh > +++ b/ci/build.sh > @@ -103,7 +103,7 @@ main() { > > run_checks check > > - if test "$CHECK_VALGRIND" != "skip" > + if test "$CHECK_VALGRIND" = "force" > then > run_checks check-valgrind > fi > -- > 2.32.0-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org