Libguestfs - Jun 2021 - [libnbd PATCH] ci: Enable python code style

On Tue, Jun 22, 2021 at 03:38:13PM +0200, Martin Kletzander
wrote:
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  ci/build.sh | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ci/build.sh b/ci/build.sh
> index 7d62a84a5d4b..4ea3fec7d512 100755
> --- a/ci/build.sh
> +++ b/ci/build.sh
> @@ -8,6 +8,7 @@ main() {
>      autoreconf -if
>  
>      CONFIG_ARGS="\
> +--enable-python-code-style \
>  --enable-gcc-warnings \
>  --enable-fuse \
>  --enable-ocaml \
It's OK as long as "someone" is going to chase up and fix the new
failures whenever flake8 changes, or we could do something like what
Nir suggests and pin a version of flake8.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/

On Wed, Jun 23, 2021 at 12:31:14PM +0100, Richard W.M. Jones
wrote:
> On Tue, Jun 22, 2021 at 03:38:13PM +0200, Martin Kletzander wrote:
> > Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> > ---
> >  ci/build.sh | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/ci/build.sh b/ci/build.sh
> > index 7d62a84a5d4b..4ea3fec7d512 100755
> > --- a/ci/build.sh
> > +++ b/ci/build.sh
> > @@ -8,6 +8,7 @@ main() {
> >      autoreconf -if
> >  
> >      CONFIG_ARGS="\
> > +--enable-python-code-style \
> >  --enable-gcc-warnings \
> >  --enable-fuse \
> >  --enable-ocaml \
> 
> It's OK as long as "someone" is going to chase up and fix the
new
> failures whenever flake8 changes, or we could do something like what
> Nir suggests and pin a version of flake8.
This isn't all that much different from GCC where new releases
inevitably trigger new compiler warnings.

As long as you have a nightly CI job that is running Fedora
rawhide, you'll detect the problems quicky and be able to
fix or ignorelist them before it has a negative impact.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|