Libguestfs - Apr 2021 - [libnbd RFC PATCH] First stab at CI infrastructure

On Thu, Apr 08, 2021 at 02:42:39PM +0100, Richard W.M. Jones
wrote:
>On Thu, Apr 08, 2021 at 02:36:22PM +0100, Richard W.M. Jones wrote:
>> >   https://gitlab.com/nertpinx/libnbd/-/pipelines/283351379
>>
>> golang seems to be failing hard there :-(
>>
>> Looks it fails with libnbd is not already installed (which is a bug).
>> I'll see if I can fix that one.
>
>Fixed now:
>https://gitlab.com/nbdkit/libnbd/-/commit/031aaefaa8f78513d76913a54b362044667a4370
>
Thanks a lot, we're getting closer now.  The only missing things are:

  - clang failures:
    https://gitlab.com/nertpinx/libnbd/-/jobs/1163504401

  - golang test failures on OpenSUSE:
    https://gitlab.com/nertpinx/libnbd/-/jobs/1163504416

  - one weird ubuntu 18.04 failure:
    https://gitlab.com/nertpinx/libnbd/-/jobs/1163504418

and if you want to be able to run `make distcheck` as well, there are
some builddir/srcdir issues in golang/Makefile.am I believe, so VPATH
building actually fails.  I added the `make distcheck` step to one of
the jobs here:

   https://gitlab.com/nertpinx/libnbd/-/jobs/1163504412

In order not to bother you with every single e-mail I would suggest that
I push some incomplete version in the repository and you can see
yourself (and others as well) how the build behaves.  What do you say?
I won't look at it earlier than tomorrow anyway.

Have a nice rest of the day,
Martin
>Rich.
>
>-- 
>Richard Jones, Virtualization Group, Red Hat
http://people.redhat.com/~rjones
>Read my programming and virtualization blog: http://rwmj.wordpress.com
>Fedora Windows cross-compiler. Compile Windows programs, test, and
>build Windows installers. Over 100 libraries supported.
>http://fedoraproject.org/wiki/MinGW
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL:
<http://listman.redhat.com/archives/libguestfs/attachments/20210408/a1ce5b2d/attachment.sig>

On Thu, Apr 08, 2021 at 05:39:17PM +0200, Martin Kletzander
wrote:
>  - clang failures:
>    https://gitlab.com/nertpinx/libnbd/-/jobs/1163504401
I don't usually enable warnings with clang, but I've pushed this which
fixes the problem above (and a further one) for me:

 
https://gitlab.com/nbdkit/libnbd/-/commit/28816a5f8829f474d07351611140f461facd0e4d
>  - golang test failures on OpenSUSE:
>    https://gitlab.com/nertpinx/libnbd/-/jobs/1163504416
This is actually because:

  checking for nbdkit... no

but we go ahead and run the golang tests anyway.  Fixed here:

 
https://gitlab.com/nbdkit/libnbd/-/commit/b15dde588f47894f9656ea62eb632156b7638b8b

but there may be more problems after this, we'll see.
>  - one weird ubuntu 18.04 failure:
>    https://gitlab.com/nertpinx/libnbd/-/jobs/1163504418
This has golang 1.10 which predates the inclusion of modules.  There's
basically no sane way to make libnbd work with both old and new
golang, so I would suggest --disable-golang on this platform.  (In
fact is it possible to disable features on different CI platforms?)
> and if you want to be able to run `make distcheck` as well, there are
> some builddir/srcdir issues in golang/Makefile.am I believe, so VPATH
> building actually fails.  I added the `make distcheck` step to one of
> the jobs here:
> 
>   https://gitlab.com/nertpinx/libnbd/-/jobs/1163504412
I think "make distcheck" is a nice-to-have but ISTR that making it
work was a lot of work for libguestfs.
> In order not to bother you with every single e-mail I would suggest that
> I push some incomplete version in the repository and you can see
> yourself (and others as well) how the build behaves.  What do you say?
> I won't look at it earlier than tomorrow anyway.
Sure, go for it.

Thanks again,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html