Martin Kletzander
2021-Mar-30 14:52 UTC
[Libguestfs] [libnbd PATCH 2/2] Add an extra info for ocamlfind dependency
Signed-off-by: Martin Kletzander <mkletzan at redhat.com> --- generator/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/generator/Makefile.am b/generator/Makefile.am index 594d23cf53fa..65935e6e330f 100644 --- a/generator/Makefile.am +++ b/generator/Makefile.am @@ -96,6 +96,7 @@ stamp-generator: echo "Source files are missing from your build."; \ echo; \ echo "Install the OCaml bytecode compiler (the program called ?ocamlc?)"; \ + echo "and OCaml findlib (program called ocamlfind)"; \ echo "and rerun ./configure && make"; \ echo; \ echo " *** *** ***"; \ -- 2.31.1
Eric Blake
2021-Mar-30 15:27 UTC
[Libguestfs] [libnbd PATCH 2/2] Add an extra info for ocamlfind dependency
On 3/30/21 9:52 AM, Martin Kletzander wrote:> Signed-off-by: Martin Kletzander <mkletzan at redhat.com> > --- > generator/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/generator/Makefile.am b/generator/Makefile.am > index 594d23cf53fa..65935e6e330f 100644 > --- a/generator/Makefile.am > +++ b/generator/Makefile.am > @@ -96,6 +96,7 @@ stamp-generator: > echo "Source files are missing from your build."; \ > echo; \ > echo "Install the OCaml bytecode compiler (the program called ?ocamlc?)"; \ > + echo "and OCaml findlib (program called ocamlfind)"; \Do we want consistent quoting between these two lines?> echo "and rerun ./configure && make"; \ > echo; \ > echo " *** *** ***"; \ >-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
Richard W.M. Jones
2021-Mar-30 16:39 UTC
[Libguestfs] [libnbd PATCH 2/2] Add an extra info for ocamlfind dependency
On Tue, Mar 30, 2021 at 04:52:06PM +0200, Martin Kletzander wrote:> Signed-off-by: Martin Kletzander <mkletzan at redhat.com> > --- > generator/Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/generator/Makefile.am b/generator/Makefile.am > index 594d23cf53fa..65935e6e330f 100644 > --- a/generator/Makefile.am > +++ b/generator/Makefile.am > @@ -96,6 +96,7 @@ stamp-generator: > echo "Source files are missing from your build."; \ > echo; \ > echo "Install the OCaml bytecode compiler (the program called ?ocamlc?)"; \ > + echo "and OCaml findlib (program called ocamlfind)"; \This shouldn't be necessary since I added this fix: https://gitlab.com/nbdkit/libnbd/-/commit/dae04165c35f45bc0d63abebf05a1d9889298dc3 The other patch is fine. Rich.> echo "and rerun ./configure && make"; \ > echo; \ > echo " *** *** ***"; \ > -- > 2.31.1 > > _______________________________________________ > Libguestfs mailing list > Libguestfs at redhat.com > https://listman.redhat.com/mailman/listinfo/libguestfs-- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top