Pino Toscano
2020-Mar-12 11:22 UTC
[Libguestfs] [libnbd PATCH] lib: remove extra @LIBS@ from pkg-config file
At the moment it is empty, so probably it does not exist. Remove it to avoid adding spurious content to the pkg-config file in case that variable will get a value in the future. --- lib/libnbd.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/libnbd.pc.in b/lib/libnbd.pc.in index ba91f49..294c090 100644 --- a/lib/libnbd.pc.in +++ b/lib/libnbd.pc.in @@ -8,4 +8,4 @@ Version: @PACKAGE_VERSION@ Description: NBD client library in userspace Requires: Cflags: -Libs: -lnbd @LIBS@ +Libs: -lnbd -- 2.24.1
Richard W.M. Jones
2020-Mar-12 14:47 UTC
Re: [Libguestfs] [libnbd PATCH] lib: remove extra @LIBS@ from pkg-config file
On Thu, Mar 12, 2020 at 12:22:23PM +0100, Pino Toscano wrote:> At the moment it is empty, so probably it does not exist. Remove it to > avoid adding spurious content to the pkg-config file in case that > variable will get a value in the future. > --- > lib/libnbd.pc.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/libnbd.pc.in b/lib/libnbd.pc.in > index ba91f49..294c090 100644 > --- a/lib/libnbd.pc.in > +++ b/lib/libnbd.pc.in > @@ -8,4 +8,4 @@ Version: @PACKAGE_VERSION@ > Description: NBD client library in userspace > Requires: > Cflags: > -Libs: -lnbd @LIBS@ > +Libs: -lnbdACK Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html
Richard W.M. Jones
2020-Mar-12 14:48 UTC
Re: [Libguestfs] [libnbd PATCH] lib: remove extra @LIBS@ from pkg-config file
On Thu, Mar 12, 2020 at 02:47:04PM +0000, Richard W.M. Jones wrote:> On Thu, Mar 12, 2020 at 12:22:23PM +0100, Pino Toscano wrote: > > At the moment it is empty, so probably it does not exist. Remove it to > > avoid adding spurious content to the pkg-config file in case that > > variable will get a value in the future. > > --- > > lib/libnbd.pc.in | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/libnbd.pc.in b/lib/libnbd.pc.in > > index ba91f49..294c090 100644 > > --- a/lib/libnbd.pc.in > > +++ b/lib/libnbd.pc.in > > @@ -8,4 +8,4 @@ Version: @PACKAGE_VERSION@ > > Description: NBD client library in userspace > > Requires: > > Cflags: > > -Libs: -lnbd @LIBS@ > > +Libs: -lnbd > > ACKBTW I have pushed this one. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://people.redhat.com/~rjones/virt-top
Reasonably Related Threads
- Re: [libnbd PATCH] lib: remove extra @LIBS@ from pkg-config file
- [PATCH] lib: remove extra @LIBS@ from pkg-config file
- Re: [PATCH] lib: remove extra @LIBS@ from pkg-config file
- [PATCH libnbd 1/3] tests: Don't use <config.h> in simple compile tests.
- [PATCH libnbd 2/3] build: Allow C programs using libnbd to be compiled against build dir.