Libguestfs - Feb 2019 - [PATCH] v2v: windows: save log file from rhev-apt installer

Store log from MSI installer. Log file will be located in firstboot
scripts-done directory with name rhev-apt.log. The path has to be
double-quoted to handle spaces in path name properly.

Hopefully this can help resolve RHBZ#1584678 someday.

Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
---
 v2v/convert_windows.ml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/v2v/convert_windows.ml b/v2v/convert_windows.ml
index 1db3c0ea6..7ea56592c 100644
--- a/v2v/convert_windows.ml
+++ b/v2v/convert_windows.ml
@@ -378,7 +378,7 @@ echo Wait for PnP to complete
 @echo off
 
 echo installing rhev-apt
-\"\\rhev-apt.exe\" /S /v/qn
+\"\\rhev-apt.exe\" /S /v/qn /v/l*vx
\"/v\\\"%cd%\\rhev-apt.log\\\"\"
 
 echo starting rhev-apt
 net start rhev-apt
-- 
2.20.1

On Thu, Feb 14, 2019 at 02:38:21PM +0100, Tomáš Golembiovský
wrote:
> Store log from MSI installer. Log file will be located in firstboot
> scripts-done directory with name rhev-apt.log. The path has to be
> double-quoted to handle spaces in path name properly.
> 
> Hopefully this can help resolve RHBZ#1584678 someday.
> 
> Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> ---
>  v2v/convert_windows.ml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/v2v/convert_windows.ml b/v2v/convert_windows.ml
> index 1db3c0ea6..7ea56592c 100644
> --- a/v2v/convert_windows.ml
> +++ b/v2v/convert_windows.ml
> @@ -378,7 +378,7 @@ echo Wait for PnP to complete
>  @echo off
>  
>  echo installing rhev-apt
> -\"\\rhev-apt.exe\" /S /v/qn
> +\"\\rhev-apt.exe\" /S /v/qn /v/l*vx
\"/v\\\"%cd%\\rhev-apt.log\\\"\"
Backslash nightmare :-/

ACK

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html

On Monday, 25 March 2019 16:06:26 CET Richard W.M. Jones
wrote:
> On Thu, Feb 14, 2019 at 02:38:21PM +0100, Tomáš Golembiovský wrote:
> > Store log from MSI installer. Log file will be located in firstboot
> > scripts-done directory with name rhev-apt.log. The path has to be
> > double-quoted to handle spaces in path name properly.
> > 
> > Hopefully this can help resolve RHBZ#1584678 someday.
> > 
> > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com>
> > ---
> >  v2v/convert_windows.ml | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/v2v/convert_windows.ml b/v2v/convert_windows.ml
> > index 1db3c0ea6..7ea56592c 100644
> > --- a/v2v/convert_windows.ml
> > +++ b/v2v/convert_windows.ml
> > @@ -378,7 +378,7 @@ echo Wait for PnP to complete
> >  @echo off
> >  
> >  echo installing rhev-apt
> > -\"\\rhev-apt.exe\" /S /v/qn
> > +\"\\rhev-apt.exe\" /S /v/qn /v/l*vx
\"/v\\\"%cd%\\rhev-apt.log\\\"\"
> 
> Backslash nightmare :-/
> 
> ACK
... and pushed now.

Thanks,
-- 
Pino Toscano