Libguestfs - Jan 2019 - Re: [PATCH] lib: Reset errno to zero to avoid erroneously returning E2BIG

This line was accidentally removed in 77fe74fc, causing
bug #1145056 (Bugzilla) to resurface.
---
 lib/utf16.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/utf16.c b/lib/utf16.c
index e099548..67fa996 100644
--- a/lib/utf16.c
+++ b/lib/utf16.c
@@ -58,6 +58,7 @@ _hivex_recode (hive_h *h, recode_type t,
       /* Reset errno here because we don't want to accidentally
        * return E2BIG to a library caller.
        */
+      errno = 0;
       size_t prev = outalloc;
       /* Try again with a larger output buffer. */
       free (out);
-- 
2.7.4

On Tue, Jan 22, 2019 at 04:43:31PM -0500, Michael Meyer
wrote:
> This line was accidentally removed in 77fe74fc, causing
> bug #1145056 (Bugzilla) to resurface.
> ---
>  lib/utf16.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/utf16.c b/lib/utf16.c
> index e099548..67fa996 100644
> --- a/lib/utf16.c
> +++ b/lib/utf16.c
> @@ -58,6 +58,7 @@ _hivex_recode (hive_h *h, recode_type t,
>        /* Reset errno here because we don't want to accidentally
>         * return E2BIG to a library caller.
>         */
> +      errno = 0;
>        size_t prev = outalloc;
>        /* Try again with a larger output buffer. */
>        free (out);
Sorry about that.  I've pushed your fix now.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW

Thanks Rich!

Just curious, when's the next hivex release scheduled to be tagged?

Best,
Michael

On Tue, Jan 22, 2019 at 5:22 PM Richard W.M. Jones <rjones@redhat.com>
wrote:
> On Tue, Jan 22, 2019 at 04:43:31PM -0500, Michael Meyer wrote:
> > This line was accidentally removed in 77fe74fc, causing
> > bug #1145056 (Bugzilla) to resurface.
> > ---
> >  lib/utf16.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/utf16.c b/lib/utf16.c
> > index e099548..67fa996 100644
> > --- a/lib/utf16.c
> > +++ b/lib/utf16.c
> > @@ -58,6 +58,7 @@ _hivex_recode (hive_h *h, recode_type t,
> >        /* Reset errno here because we don't want to accidentally
> >         * return E2BIG to a library caller.
> >         */
> > +      errno = 0;
> >        size_t prev = outalloc;
> >        /* Try again with a larger output buffer. */
> >        free (out);
>
> Sorry about that.  I've pushed your fix now.
>
> Rich.
>
> --
> Richard Jones, Virtualization Group, Red Hat
> http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http://rwmj.wordpress.com
> Fedora Windows cross-compiler. Compile Windows programs, test, and
> build Windows installers. Over 100 libraries supported.
> http://fedoraproject.org/wiki/MinGW
>
>
-- 
*Michael Meyer*
Software Engineer
Datto, Inc.
(475) 288-1327
www.datto.com

<http://www.datto.com/support-sig/>

Join the conversation! [image: Facebook]
<http://www.facebook.com/dattoinc> [image:
Twitter] <https://twitter.com/dattosupport> [image: LinkedIn]
<https://www.linkedin.com/company/datto-inc-> [image: Blog RSS]
<http://blog.datto.com/blog> [image: Slideshare]
<http://www.slideshare.net/backupify> [image: Spiceworks]
<https://community.spiceworks.com/pages/datto>