Libguestfs - Aug 2018 - Re: [PATCH 1/2] v2v: rhv-upload-plugin: Handle send send failures

On Tue, Aug 21, 2018 at 01:15:02AM +0300, Nir Soffer
wrote:
> The oVirt server may fail a PUT request before reading all request body.
> However before closing the connection, it writes a detailed error
> response, that will make debugging issues like expired tickets much
> easier to handle. If we don't get the response and log the error, the
> error may be lost when the daemon log is rotated.
This series looks fine, I'll push it in a minute.

Couple of questions:

(1) Are we using the nbdkit enhanced Python error reporting yet?
What's stopping us if we are not?

(2) Is there a BZ associated with this change?  If not, we'll need one
if you want to get these changes into RHEL.

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW

On Tue, Aug 21, 2018 at 2:02 PM Richard W.M. Jones <rjones@redhat.com>
wrote:
> On Tue, Aug 21, 2018 at 01:15:02AM +0300, Nir Soffer wrote:
> > The oVirt server may fail a PUT request before reading all request
body.
> > However before closing the connection, it writes a detailed error
> > response, that will make debugging issues like expired tickets much
> > easier to handle. If we don't get the response and log the error,
the
> > error may be lost when the daemon log is rotated.
>
> This series looks fine, I'll push it in a minute.
>
> Couple of questions:
>
> (1) Are we using the nbdkit enhanced Python error reporting yet?
> What's stopping us if we are not?
>
In request_failed() we raise RuntimeError, so it should log a traceback, but
I did not see a traceback, maybe because I did not test it in verbose mode.

(2) Is there a BZ associated with this change?  If not, we'll need
one
> if you want to get these changes into RHEL.
>
Not yet, the only thing we have is https://bugzilla.redhat.com/1619019,
showing why this change is important.

I will open a new bug for this.

Nir

On Tue, Aug 21, 2018 at 02:40:49PM +0300, Nir Soffer
wrote:
> On Tue, Aug 21, 2018 at 2:02 PM Richard W.M. Jones
<rjones@redhat.com>
> wrote:
> 
> > On Tue, Aug 21, 2018 at 01:15:02AM +0300, Nir Soffer wrote:
> > > The oVirt server may fail a PUT request before reading all
request body.
> > > However before closing the connection, it writes a detailed error
> > > response, that will make debugging issues like expired tickets
much
> > > easier to handle. If we don't get the response and log the
error, the
> > > error may be lost when the daemon log is rotated.
> >
> > This series looks fine, I'll push it in a minute.
> >
> > Couple of questions:
> >
> > (1) Are we using the nbdkit enhanced Python error reporting yet?
> > What's stopping us if we are not?
> >
> 
> In request_failed() we raise RuntimeError, so it should log a traceback,
but
> I did not see a traceback, maybe because I did not test it in verbose mode.
If you see anything at all, then you'd see the traceback.

It seems more likely that whatever version of nbdkit being used does
not include:

 
https://github.com/libguestfs/nbdkit/commit/72c0d64a47db642cafa89884f2ee554bd0b8e822

This has now been backported to the 1.2 & 1.4 branches as well.  Do
you know what version (of nbdkit) they are testing with?

Thanks for opening the bug, let me know the BZ# when you have it.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org